- @dcam opened merge request.
- 🇺🇸United States dcam
This test is bad as written because
upload_max_filesizeandpost_max_sizecan't be set withini_set().
It is possible to configure PHP for no upload size limit, in which case the File widget says "Files must be less than 0 bytes", which is useless.
Old code was assumed there is always a limit, while the docs for file_upload_max_size explicity assume this case to be valid.
Attached patch only shows validator hint when a size limit is in effect.
[PHP]
upload_max_filesize = 0;
post_max_size = 0;
Address feedback in #7
Write test
review
commit
Before
After
Needs work
11.0 🔥
file system
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This test is bad as written because upload_max_filesize and post_max_size can't be set with ini_set().