Don't display size limit when there is no limit configured for file upload

Created on 25 August 2015, about 10 years ago

Updated 12 July 2025, 2 months ago

It is possible to configure PHP for no upload size limit, in which case the File widget says "Files must be less than 0 bytes", which is useless.

Old code was assumed there is always a limit, while the docs for file_upload_max_size explicity assume this case to be valid.

Attached patch only shows validator hint when a size limit is in effect.

[PHP]
  upload_max_filesize = 0;
  post_max_size = 0;

Address feedback in #7
Write test
review
commit

Before

After

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

file system

Created by

🇩🇪Germany mschuster91

Live updates comments and jobs are added and updated live.

Needs backport to D7
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 2 months ago →
🇺🇸United States dcam
dcam → changed the visibility of the branch 2557319-dont-display-size to hidden.
Comment 2 months ago →
🇺🇸United States dcam
dcam → changed the visibility of the branch 11.x to hidden.
@dcam opened merge request.
Comment 2 months ago →
🇺🇸United States dcam
This test is bad as written because upload_max_filesize and post_max_size can't be set with ini_set().
Comment about 2 months ago →
🇺🇸United States dcam
Big thanks to @acbramley for the test guidance.
Comment 13 days ago →
🇺🇸United States smustgrave
is there an existing test we could extend or even turn into a non functional test? Since this test isn't doing a submission it's just showing help text seems overkill to do a full bootstrap for it.

Also proposed solution appears to be empty.
Comment 13 days ago →
🇺🇸United States dcam
I converted the Functional test to a Kernel test and updated the proposed resolution.

Production build 0.71.5 2024