- Status changed to Needs review
about 2 years ago 9:45am 20 March 2023 - Status changed to Needs work
about 2 years ago 1:49pm 20 March 2023 - 🇺🇸United States smustgrave
#43 was not addressed.
Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not applyTo receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines → for more information. - Merge request !12125Issue #1516242 by snehi, anil.gangwal, shreya shetty, dinesh18, ottlik, wiifm,... → (Open) created by smustgrave
- 🇺🇸United States smustgrave
Posted in slack and @chx was kind enough to give a look and apparently this needs some work.