Contrib.social

Move CommentStorage::getUnapprovedCount() to CommentManager

Open on Drupal.org →
Created on 10 August 2014, almost 11 years ago
Updated 1 May 2025, 11 days ago

I spotted we have two functions that are similar in name: CommentStorage::getUnapprovedCount()... and CommentManager::getCountNewComments(). Inconsistent, plus it was decided to move everything non-SQL-specific into CommentManager.

So, move CommentStorage::getUnapprovedCount()... and CommentManager::getCountUnapproved() before we get used to it.

Since noone uses getUnapprovedCount() and it's only a month old: can we just get away with not doing an extra change notice, and adjusting the current one → ? I'll keep a note about the brief existence of CommentStorage::getUnapprovedCount().

Beta phase evaluation

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

comment.module

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
  • API clean-up

    Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 11 days ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024