🇺🇸United States @rosemarystanley

Fix is in new release 4.2.1

I created a new MR. I forgot to change the category value in the FieldType file. Let me know if that helps.

Created 4.2.0 → for this and a few other bug fixes

Created 4.2.0 → for this and a few other bug fixes

Created 4.2.0 → for this and a few other bug fixes

New Drupal API Changes: New API for defining field type categories →

I added a new MR that you can use the changes to see if that fixes your issue.

New Drupal API Changes: New API for defining field type categories →

Whoops sorry this was an issue introduced with a typo in your other bug report #3513508 ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase 🐛 ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase Active

I have updated the merge request there. If you reapply the changes and try again. Please see if that resolves your issue

Thanks for the report. please see the MR I created and give it a try. let me know if that solves your issue. Thanks!

rosemaryreilman → made their first commit to this issue’s fork.

Ok created release 4.0.2 that has this fixed. Closing this issue. Please feel free to reopen if you need!

I have confirmed that the automatic crop image effect is not working and have committed a fix on the dev branch. The issue was there was a missing event type in the dispatch of the automatic crop provider list.

$this->eventDispatcher->dispatch($event); should have been
$this->eventDispatcher->dispatch($event, Events::AUTOMATIC_CROP_PROVIDERS);

Creating version 4.1.1 for release to fix this

Thanks so much for providing a patch. I will plan on reviewing early next week.

Ok so there may still be a bug with the Automated Crop style effect. But yeah the automated crop effect, likely would not show in the IWC because it skips over the ability to manually set the crop. However, the generated image should be created so I'll look into that.

As for your question about the Manual crop changes... yes they should change right away in a normal file storage setup but I'm not sure how your S3 is set up. Does it upload/fetch files on cron? Maybe try checking there? Or try clearing cache for it to fetch something new just to test.

Ok couple of questions

• Did you set any hard or soft limits on the crop?
• Are you using the Automated Crop Effect or the Manual Crop effect with an automated crop provider?
• In the widget settings, do you have "Show default crop area" checked? I have noticed that this helps to see what the automatic crop will look like. Otherwise it won't show the crop box in the Image Widget Crop until you manually set/change the default.
• Is it just not showing in the IWC view or have you tried looking at the generated image style?

Fixed in 4.0.1

Fixed in 4.0.1

Fixed in 4.0.1

rosemaryreilman → made their first commit to this issue’s fork.

Thanks for this!

rosemaryreilman → made their first commit to this issue’s fork.

Thanks so much for the fix. Merging in!

rosemaryreilman → made their first commit to this issue’s fork.

Issue has been inactive for 4 months. I'm going to merge the code into 4.x branch and create an alpha2 release.

Code has been merged and ticket has been inactive. Closing as fixed.

All changes have been merged and D11 is released

New release 4.0.0 has updates

Went ahead and added this to new release 4.0.0 after testing on a couple of our sites. Please reopen if necessary.

Please see the merge request I created..and patch the module with it. I was able to recreate the issue you are seeing and I believe I resolved it. Thanks!

Thanks for reopening and reporting. We will take a look as soon as we can.

Ok I reviewed the other issues and created a PR to review and try out to see if that resolves your issue.

rosemaryreilman → made their first commit to this issue’s fork.

Ok created a merge request with some changes to integrate the entity save and mapping of other CC fields. I have no added custom field support yet but thought this might be a good start. Feel free to give it a try.

That's great. I am going to keep this open for now as a feature request because I'd like to integrate this as an option with the User registration form.

The line should actually should be

$body->street_address = (object) [
    'street' => $data['street'],  
    'city' => $data['city'], 
    'state' => $data['state'], 
    'postal_code' => $data['postal_code'], 
    'country' => $data['country'],
  ];

I think that's the issue

Hello and thanks for reaching out. I will try to take a closer look as soon as I can.

A couple of suggestions on what you can look at in the meantime:

There are hooks that fire before sending user data to constant contact. This one could be helpful:
hook_ik_constant_contact_contact_data_alter details can be found in ik_constant_contact.api.php

That may be a little more complicated but could be useful.

The email address from an entity is mapped via field settings in Drupal\ik_constant_contact\Plugin\Field\FieldType\ConstantContactListItem
Likely this file may need to be modified to map the other user/entity fields.

I'll take a look as soon as I am able.
Thanks!

Added a pre-release for testing
https://www.drupal.org/project/ik_constant_contact/releases/3.1.10-rc1 →

Added a pre-release for testing
https://www.drupal.org/project/ik_constant_contact/releases/3.1.10-rc1 →

Taking a look, thanks for adding a patch

Changes up to this point applied to 4.x-dev branch

Fixed in →

Fixed in →

Fixed with →

Reapplied patch and will be releasing 3.0.3 with the correction. It must've gotten lost in the merge from the another issue.

rosemaryreilman → made their first commit to this issue’s fork.

Closing due to intactivity

My goodnes! thanks for catching that @ddiestra

Creating 3.1.9 release shortly

Patch applied and merged to dev branch.

Thank you for submitting the bug report and patch. I'll be reviewing as soon as I can.

Thanks all for your patches & commits. I'm in the process of releasing 3.1.8 that will have this bug fix in. I did go ahead and remove the token config save (it was outdated code and should have been removed before... and should have been changed to the saveTokens method)

Thanks I'll take a look and review as soon as I can.

Closing. This doesn't seem to be an issue anymore.

Merge request committed. New release 3.1.7 has been created and documentation is updated to include quotes. Thanks!

Thanks so much joel for the merge request. I'll review as soon as I can. Thanks.

Fix is available in v 3.1.5 or higher