Contrib.social

Aspect ratio is not used if the width is bigger than 999

Open on Drupal.org →
Created on 13 January 2025, 9 days ago

Problem/Motivation

When fixing 🐛 DivisionByZeroError: Division by zero in Drupal\automated_crop\AbstractAutomatedCrop->setAspectRatio() Active , I noticed that AbstractAutomatedCrop::ASPECT_RATIO_FORMAT_REGEXP only matches widths/heights of maximum three digits. Is this intentional? What if you want to use an aspect ratio of e.g. 1280:500?

Proposed resolution

Also allow aspect ratios with a width/height of more than three digits.

🐛 Bug report
Status

Active

Version

4.0

Component

Code

Created by

🇧🇪Belgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024