johnpicozzi → credited bdimaggio → .
johnpicozzi → credited bdimaggio → .
Hey there — this is a tricky one. We have seen it a couple of times (well, once → that I know of) over the years we've been maintaining the Mailchimp suite, but we've never successfully pinned down what causes it. I am encouraged that it has only made it to the issue queue that one time, but of course I'm sure that's no consolation for you.
To try and make more progress with it, let's get all the info we can.
- Can you paste here the entire error message you're seeing (including all HTML)?
- Did the problem definitively start at a certain point (e.g. after upgrading to a certain version of the module)?
- If you're not already using OAuth rather than an API key to authenticate, can you try that (admittedly, a shot in the dark)?
@frazras, sorry for the slow response time here. I have ideas, but first — is this still an issue for you?
Yep, definitely — we have a time blocked off next week for this work + release. Sorry for the wait.
Hear you @Matt B! We've got this review (and hopefully commit/release) on the schedule for this coming week.
bdimaggio → created an issue.
Great to see both of these, @pfrenssen. We'll be able to review next week, when the current batch of work settles. Thank you very much!
xenophyle → credited bdimaggio → .
Okay, for the 7.x-5.x branch of this project, locking the required version of thinkshout/mailchimp-api-php at 2.1.3 (but allowing any version between 1.0.8 and 2.1.3, inclusive, so that people who are happy with version aren't forced to upgrade).
@TorgosPizza, I just wanted to let you know we're working on this. I'm looking at a temporary fix where we just downgrade the required version of the Mailchimp API library, to get things working again while we do the heavier lifting of getting the D7 version working with that library's 3.x version. More on this today or tomorrow.
bdimaggio → made their first commit to this issue’s fork.
Hmm... could you point to some documentation for that? I've just tested Gateway->post() without that GuzzleHttp\Client use statement, and it worked without PHP errors (or even notices).
Updating credentials to reflect:
- We're now compatible with Drupal 10
- Firstpay Gateway removed their test creds
- ...and made it so that you have to call them to get some of your gateway information and use their product
Thanks for this, @sarwan! One other tweak: is the use statement for GuzzleHttp\Client in src/Rest/Gateway.php necessary?
bdimaggio → created an issue.
Hey @DieterHolvoet — thanks for offering to pitch in! Yeah, as you can tell from our response times, we're a bit underwater this summer. We're happy to accept. I've given you "Write to VCS," "Administer issues," and "Edit project" perms for now; we may need to retain control over the releases. How does this work for you?
Since the tests are now updated, I'm closing this issue. Fixing should be done in 📌 2.x branch tests failing Needs review .
bdimaggio → created an issue. See original summary → .
I like this! Would be nice too if there were a default configuration included that, on installation via a post-update hook,
1. placed the block in the installing site's user-facing theme automatically (in say the first available region--doesn't matter because the CSS takes care of presentation)
2. set block visibility so that by default, this only showed up on node view pages. Could restrict by page and choose node/* or, if that's too broad, restrict by content type and auto-choose all available content types.
Just wanted to let folks know we're on this and will address within the week.
Update: thanks for the bump, @apaderno. Have just updated test configuration and would be grateful for fixes if @MegaChriz is still game to provide them.
Hey @MegaChriz -- makes sense to me! I've updated the configuration per your suggestion, and sure enough the tests need love. I'd so appreciate your contribution if you wanted to work on those in this issue.
@MegaChriz, we'd absolutely welcome patches in that vein. That said, would you be interested in contributing those through the issue queue without necessarily taking on co-maintainership?
I recognize that this is something of a turnaround from my position in #9, but now that the current batch of maintainers (all 12 of us!) has gotten a process dialed in for consistently maintaining this module, I am a little reluctant to change that process. That said, if you strongly prefer to become a co-maintainer, we'd be happy to accommodate.
@Anybody, I was getting at this in #3304436-17: Drupal 10 compatibility fixes → -- that is intended to be a stable release, as well as D10-compatible. We're still wrapping up some documentation work with Mailchimp themselves so it looks likely that we'll need to push that release date a little, possibly until the week of 3/13. But rest assured that it's coming soon! If you need D10 compatibility, or any of the functionality I talk about in #3304436-17: Drupal 10 compatibility fixes → , by all means start using the latest version of the module in the 2.x branch -- it's stable and ready for release, per our own and Mailchimp's QA.
Committed and merged. Thanks, all!
Hey @heddn! Thanks so much for the offer. We're still on track for a D10-compatible release this week. Given that, I'm going to close this for now, but if we run into the need for more people power on this front, I hope you won't mind if I ping you again.
bdimaggio → created an issue.
Hello all -- as I just posted in #3304436-17: Drupal 10 compatibility fixes → , there was just an organizational snafu on our side that prevented the right folks from actually seeing these messages. We've actually been pretty hard at work on a new release of this module, to include D10 compatibility and slated for release by 3/3/23 or sooner. That said, it's open source -- @japerry, if you want to join the team, you're very welcome! Given the above, what's your preference?
Hey all -- Ben from ThinkShout here. I'm very sorry we've missed this patch so far! We're still very actively maintaining and improving this module (expect to see ✨ Add support for Multiple Tags Needs review , ✨ Subscribe fields with interest groups Fixed , ✨ Make double opt-in message configurable Fixed , and ✨ Send test mail Fixed fixed, along with a significant improvement to authentication, in a release either next week or the following one -- just waiting on some documentation changes on Mailchimp's side). We did, however, recently switch the team doing the maintenance; because we haven't actually cut the release yet, those folks aren't yet maintainers and didn't see these messages. We're fixing that now, so that these emails go to the right people.
More importantly for this ticket, we're planning to include it and 🐛 preg_quote(): Passing null to parameter #1 ($str) of type string is deprecated Fixed in that upcoming release. So in short, this module should be D10-compatible by 3/3/23 at latest. Sorry for the holdup!
Future Googlers: this isn't fixed in this module (in my experience, the patch didn't address the issue, nor has it been incorporated into the module). I was able to address it by updating Field Group from 3.2 to 3.4. See https://www.drupal.org/project/field_group/issues/2951175 🐛 Infinite recursion on field_group_field_info_max_weight()/field_group_info_groups() Fixed for details.