Drupal 10 compatibility fixes

MR got applied cleanly, but this needs work!

================================================================================
Mailchimp, --
Scanned on Thu, 01/26/2023 - 01:32

FILE:
web/modules/contrib/mailchimp/modules/mailchimp_campaign/src/Form/MailchimpCampa
ignForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 139  The 'mailchimp_campaign/campaign-form' library is not       
                    defined because the defining extension is not installed.    
                    Cannot decide if it is deprecated or not.                   
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/mailchimp/modules/mailchimp_campaign/src/Entity/MailchimpCam
paignViewBuilder.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 50   The 'mailchimp_campaign/campaign-view' library is not       
                    defined because the defining extension is not installed.    
                    Cannot decide if it is deprecated or not.                   
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/mailchimp/modules/mailchimp_campaign/src/Controller/Mailchim
pCampaignController.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 298  The 'mailchimp_campaign/google-jsapi' library is not defined
                    because the defining extension is not installed. Cannot     
                    decide if it is deprecated or not.                          
--------------------------------------------------------------------------------
Check manually 299  The 'mailchimp_campaign/campaign-stats' library is not      
                    defined because the defining extension is not installed.    
                    Cannot decide if it is deprecated or not.                   
--------------------------------------------------------------------------------

Is there any roadmap for Drupal 10?

If it is tested and released, please issue it!

Hey all -- Ben from ThinkShout here. I'm very sorry we've missed this patch so far! We're still very actively maintaining and improving this module (expect to see ✨ Add support for Multiple Tags Needs review , ✨ Subscribe fields with interest groups Fixed , ✨ Make double opt-in message configurable Fixed , and ✨ Send test mail Fixed fixed, along with a significant improvement to authentication, in a release either next week or the following one -- just waiting on some documentation changes on Mailchimp's side). We did, however, recently switch the team doing the maintenance; because we haven't actually cut the release yet, those folks aren't yet maintainers and didn't see these messages. We're fixing that now, so that these emails go to the right people.

More importantly for this ticket, we're planning to include it and 🐛 preg_quote(): Passing null to parameter #1 ($str) of type string is deprecated Fixed in that upcoming release. So in short, this module should be D10-compatible by 3/3/23 at latest. Sorry for the holdup!

To get this to work, you must first do
composer require thinkshout/mailchimp-api-php:^3.0
and then
composer require 'drupal/mailchimp:2.x-dev@dev' -W

I am not seeing the reported issue. Perhaps the resource was unavailable when you tried it yesterday? Here are the steps that worked for me just now:

rm -rf vendor
rm composer.lock
composer require thinkshout/mailchimp-api-php:^3.0

Yeah, I don't get #20 either, you don't actually have to require thedependency unless you had it manually required before with v2.

That change was also not introduced here (switching to v3 of the library), but since there was no stable release yet of that change, I guess this will be what forces people to update to those versions, and the API changes there are a bit problematic for a minor update, see https://github.com/thinkshout/mailchimp-api-php/issues/112 for my case. A solution for that would be appreciated :)

Thanks for verifying Berdir. And thanks for the feedback on the BC issue. I have a PR ready for review to fix that issue https://github.com/thinkshout/mailchimp-api-php/pull/113. Changing this issue status back to fixed and will file a separate issue for that.

I still get a failure:
- Installing drupal/layout_builder_styles (2.0.0): Extracting archive
- Installing drupal/lb_accordion (1.0.6): Extracting archive
- Installing thinkshout/mailchimp-api-php (3.0.0-rc4): Extracting archive
- Installing drupal/mailchimp (dev-2.x 646516b): Cloning 646516b0e9 from cache
Install of drupal/mailchimp failed
- Installing drupal/markup (dev-1.x 3387295): Cloning 3387295260 from cache
- Installing drupal/menu_item_role_access (2.1.0): Extracting archive
- Installing drupal/module_filter (4.0.1): Extracting archive
- Installing drupal/nodeaccess (2.0.0-alpha2): Extracting archive
- Installing google/recaptcha (1.3.0): Extracting archive
- Installing drupal/captcha (1.9.0): Extracting archive
- Installing drupal/recaptcha (3.1.0): Extracting archive
- Installing drupal/responsive_tables_filter (1.17.0): Extracting archive
- Installing drupal/scroll_blocks (2.0.0-alpha5): Extracting archive
- Installing drupal/slick (2.7.0): Extracting archive
- Installing drupal/slick_extras (1.0.0-rc7): Extracting archive
- Installing drupal/slick_views (2.6.0): Extracting archive
- Installing symfony/css-selector (v6.2.5): Extracting archive
- Installing tijsverkoyen/css-to-inline-styles (2.2.6): Extracting archive
- Installing swiftmailer/swiftmailer (v6.3.0): Extracting archive
- Installing html2text/html2text (4.3.1): Extracting archive
- Installing drupal/mailsystem (4.4.0): Extracting archive
- Installing drupal/swiftmailer (2.4.0): Extracting archive
- Installing drupal/tara (10.0.4): Extracting archive
- Installing drupal/thex (9.2.0): Extracting archive
- Installing drupal/user_field_value (8.1.3): Extracting archive
- Installing drupal/vani (10.0.0): Extracting archive
- Installing drupal/verf (2.0.0): Extracting archive
- Installing drupal/views_area_custom_block (1.0.0-alpha2): Extracting archive
- Installing drupal/views_attributes (1.0.0): Extracting archive
- Installing drupal/views_infinite_scroll (2.0.1): Extracting archive
- Installing drupal/views_slideshow (5.0.0): Extracting archive

It was my host. They had to increase git resources for me.

Any plans for a new stable release @aprice42? That would be nice :)

@Anybody, I was getting at this in #3304436-17: Drupal 10 compatibility fixes → -- that is intended to be a stable release, as well as D10-compatible. We're still wrapping up some documentation work with Mailchimp themselves so it looks likely that we'll need to push that release date a little, possibly until the week of 3/13. But rest assured that it's coming soon! If you need D10 compatibility, or any of the functionality I talk about in #3304436-17: Drupal 10 compatibility fixes → , by all means start using the latest version of the module in the 2.x branch -- it's stable and ready for release, per our own and Mailchimp's QA.

Thanks for the explanation @bdimaggio!!! :)

Automatically closed - issue fixed for 2 weeks with no activity.