Contrib.social

Use targetted gotos instead of multi-level breaks for cleaner code

Open on Drupal.org →
Created on 27 June 2011, about 14 years ago
Updated 14 August 2025, about 11 hours ago

Multi-level breaks are difficult to grok. PHP 5.3 introduces the goto statement as a cleaner alternative: http://php.net/manual/en/control-structures.goto.php

There are three places in core where we use multi-level breaks. I have replaced all of them with gotos and the code is now much cleaner.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component

base system

Created by

🇬🇧United Kingdom jbrown

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 11 hours ago →
    🇺🇸United States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024