- 🇨🇦Canada liquidcms
Patch from #47 doesn't apply to D9.4 (due to the smallest change in Umani demo config files).
This patch works for 9.4. Haven't tested with 9.5 but suspect it works there as well.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 9:19am 5 January 2024 - Status changed to Needs work
over 1 year ago 2:53pm 5 January 2024 - 🇺🇸United States smustgrave
Seems to have a test failure
Left some comments on MR.
Previously tagged for issue summary and screenshots.
Leaving tests tag as they will be needed for post_update hook.
- 🇨🇦Canada joseph.olstad
Rolled a patch for 10.2.5 from merge request 6038
clean for 10.2.5
- First commit to issue fork.
- 🇪🇸Spain vidorado Logroño (La Rioja)
vidorado → changed the visibility of the branch 11.x to hidden.
- 🇪🇸Spain vidorado Logroño (La Rioja)
- Updated Issue Summary.
- Rebased the MR over the most recent 11.x branch.
- Resolved all GitLab threads.
- Added a post_update hook and a test for it.
The MR Gitlab pipeline is failing and I believe it has to do with some unrelated problem in the 11.x branch. Not setting this issue to "Needs Review" until this is solved.
- 🇪🇸Spain vidorado Logroño (La Rioja)
Just figured out that the failing of:
- Drupal\Tests\package_manager\Build\PackageInstallTest
- Drupal\Tests\package_manager\Build\PackageInstallSubmoduleTest
- Drupal\Tests\package_manager\Build\PackageUpdateTest
with the error message
Some modules have database schema updates to install. You should run the database update script immediately
was caused by the incorrect placement of the post_update hook function in thelink.module
file instead of the requiredlink.post_update.php
file. - 🇳🇿New Zealand jonathan_hunt
This patch applies to Drupal 10.4.2 ok, but I want to use a link field to store links to files such as
public:///interactive/zoomify/mytiles
and I get "The URI 'public:///interactive/zoomify/mytiles' is invalid. You must use a valid URI scheme. Use base: for a path, e.g., to a Drupal file that needs the base path. Do not use this for internal paths controlled by Drupal."Should I be able to set Allowed protocols to
public, private
? If so, there may be more work required. If not, this should be made clear in the issue and UI? - 🇪🇸Spain vidorado Logroño (La Rioja)
@jonathan_hunt, if you add the "public" protocol in a link field configuration (after applying the changes in this issue fork: https://git.drupalcode.org/issue/drupal-2031149) you will be able to add links like
public://whatever/you/want/file.pdf
, but those URIs will not be converted to an URL. You will have to process them in a custom hook.Maybe the module Linkit ( https://www.drupal.org/project/linkit → ) would address what you want? Although a relative path would be stored in the field, instead of a
public://
style URI, the public directory is not likely to change, so it would be enough for you, depending on the case. The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇨🇦Canada joseph.olstad
patch file for D10.4.6 , upgrading a D10.3.x site for a client