Gin Toolbar compatibilty

Created on 2 November 2023, almost 2 years ago

Find a way to get the rebuild cache button into the Gin toolbar.

Feature request
Status

Active

Version

1.0

Component

User interface

Created by

leymannx Berlin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @leymannx
  • First commit to issue fork.
  • 🇬🇧United Kingdom scott_euser

    Given that Gin is now Drupal CMS + Navigation & Top bar are in place, these actions are typically more suitable now within the Navigation.

    This MR creates a block but could use someone to style it to match navigation.

    Steps to install:

    1. Ensure dependencies Gin (contrib/Drupal CMS) & Navigation module (Core) are enabled
    2. Go to Admin > Config > Navigation Blocks
    3. Add 'Rebuild cache' in the add block area, untick show title, and Save

    There is probably some way to install it automatically but not sure how and probably best as a follow-up.

    Here is how it looks now with the MR:

  • Pipeline finished with Success
    25 days ago
    Total: 175s
    #556429
  • 🇬🇧United Kingdom scott_euser

    Actually could just leverage the Navigation module:

    Custom icon could be a potential follow-up too, but think its not worth being a blocker.

  • Pipeline finished with Success
    25 days ago
    Total: 149s
    #556439
  • Pipeline finished with Success
    25 days ago
    Total: 239s
    #556441
  • leymannx Berlin

    Ah you can just add blocks into the new navbar, okay.

    Yeah, we would need to find a ways this gets placed automatically.

    @scott – What do you mean with this:

    Actually could just leverage the Navigation module

  • 🇬🇧United Kingdom scott_euser

    This commit essentially https://git.drupalcode.org/project/rebuild_cache_access/-/merge_requests... - no css needed in the end, it just takes the styling from Navigation module defaults so less maintenance burden also if they change things

  • 🇬🇧United Kingdom scott_euser

    Yeah the problem with placing the block is we need to check if navigation is installed, but also need to react if it's not yet installed and later gets installed. I'll see if I can spend a bit more time on this to see how to do that

  • Pipeline finished with Success
    23 days ago
    Total: 139s
    #557686
  • 🇬🇧United Kingdom scott_euser

    Okay that now handles:

    • New module install, navigation not yet enabled but gets installed later (hook_modules_installed kicks in)
    • New module install, navigation already enabled (hook_install kicks in)
    • Existing module update, navigation already enabled (hook_update_N kicks in)
    • Existing module update, navigation not yet enabled but gets installed later (hook_modules_installed kicks in)

    I think this needs a new 2.x to make this Drupal 11+ only

  • Pipeline finished with Success
    22 days ago
    Total: 143s
    #558984
  • 🇬🇧United Kingdom scott_euser

    Feedback from @AstonVictor addressed btw, back to ready for review. Updated the issue summary to make it more clear

  • Pipeline finished with Success
    2 days ago
    Total: 231s
    #574633
  • Pipeline finished with Success
    2 days ago
    #574648
Production build 0.71.5 2024