Leave preview points to undefined instead of node's edit page

I have created a path with the proposed solution I mentioned, on our projects solve this error.
node_previews_dialog_fix.patch →

I found another issue with the same problem https://www.drupal.org/project/drupal/issues/3308432#comment-16139164 💬 The link on the Image tag is redirecting to an undefined page from the node preview screen. Active

This here is a follow up of that other issue.

Re-uploading the patch from #3308432-42: The link on the Image tag is redirecting to an undefined page from the node preview screen → that fixes this issue. Credit needs to be given to @keshavv.

Hmmm, okay, just noticed now that #10 is just reverting what was done in 💬 The link on the Image tag is redirecting to an undefined page from the node preview screen. Active , so I guess this can't be the fix. Looks like we have to check both. Like this maybe:

let href = event.currentTarget.href;
if (href === undefined) {
  href = event.target.href;
}
window.top.location.href = href;

Fixes need to land in 11.x first as the development branch. Also fixes should be in MRs vs patches.

As a bug will also need test coverage too.

Thanks!

MRs is nice yeah, got created already. But as long as GitLab doesn't offer a way to get static, non-changing patches, we still need that patch here.

FYI you had it right the first time. MR has to go to 11.x first. Then depending when it lands committer decides to backport to relevant branches.

Would have needed a rebase first.

norman.lol → closed merge request !12997