- Issue created by @trackleft2
- Merge request !136Issue #3500630 provide a better way of including the nouislider library. β (Merged) created by trackleft2
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
trackleft2 β changed the visibility of the branch 3500630-demonstrate-a-better to hidden.
- leymannx Berlin
Running
composer require drupal/better_exposed_filters
and pushing the updated composer.json and .lock file, my colleagues pull and upon runningcomposer install
the get an error:- Required package "leongersen/nouislider" is not present in the lock file.
This usually happens when composer files are incorrectly merged or the composer.json file is manually edited.
Read more about correctly resolving merge conflicts https://getcomposer.org/doc/articles/resolving-merge-conflicts.md
and prefer using the "require" command over editing the composer.json file directly https://getcomposer.org/doc/03-cli.md#require-r
Composer [install -n] failed, composer command failed: exit status 4. stderr=Re-running
composer require drupal/better_exposed_filters
then updates the .lock file again withleongersen/nouislider
in it.So we should either inform people about needing to run
composer require drupal/better_exposed_filters
twice or we follow the approach of either providing a libraries.composer.json or add the library intobetter_exposed_filters
' composer.json like for example the Photoswipe contrib module does it: https://git.drupalcode.org/project/photoswipe/-/blob/5.x/composer.json?r...I honestly don't understand why we would create a mirror of a third party library on drupal.org and try to pull it in like that.
-
smustgrave β
committed 4980b492 on 7.1.x authored by
trackleft2 β
Issue #3500630 provide a better way of including the nouislider library.
-
smustgrave β
committed 4980b492 on 7.1.x authored by
trackleft2 β
- πΊπΈUnited States smustgrave
Not sure know what you mean need to run twice. With this change though shouldn't need to
- leymannx Berlin
Not sure how mirroring a third party JS library on drupal.org should be any good.