- Issue created by @Ruuds
- Status changed to Needs review
5 months ago 8:18am 16 July 2024 - 🇳🇱Netherlands Ruuds
All what is left are code style issues which are addressed in #3422332
- Status changed to RTBC
2 months ago 9:41am 14 October 2024 - leymannx Berlin
This is working super-nicely. Used it to switch to a different template depending on the current interface language.
use Drupal\mailchimp_transactional_template\Entity\TemplateMap; /** * Implements hook_mailchimp_transactional_template_map_alter(). */ function MYMODULE_mailchimp_transactional_template_map_alter(TemplateMap &$template_map, $module_key, $module) { if (\Drupal::languageManager()->getCurrentLanguage()->getId() === 'is') { $template_map->set('template_name', 'icelandic-mail'); } }
--
Raising prio due to inactivity.
- leymannx Berlin
@Ruuds – You can link to other issues from within a comment like that:
\[\#3422332\]
. 🙂 - 🇧🇪Belgium dieterholvoet Brussels
@leymannx inactivity is not a reason to raise the priority of issues, especially not when it's about a feature request. Please stop doing this.
-
dieterholvoet →
committed 6a08a44d on 1.0.x authored by
ruuds →
Issue #3461728 by ruuds, dieterholvoet: Create alter hook for template...
-
dieterholvoet →
committed 6a08a44d on 1.0.x authored by
ruuds →
- leymannx Berlin
Feature requests may be marked major based on their value to the project overall and/or the scope of work to complete them. Major feature requests are often identified by core product managers, initiative coordinators, or subsystem or topic maintainers.
Examples of major features:
Providing a better UX for creating, editing & managing draft revisions
From https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →
But yeah, I should have justified it. And it's still up to the maintainers to decide if it's justified.
And I also remembered this inactivity=major correlation from security advisory coverage review queue. Which of course does not apply here.
I apologize.