- Issue created by @leymannx
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I think it would be best to do this in a separate contrib module.
- leymannx Berlin
Hm, maybe yeah. On the other hand: Shouldn't a rating element provided by Webform core be accessible OOTB?
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Yes, I think the solution is to move all Webform functionality that depends on libraries into separate projects. We can at least start by not adding more libraries to Webform core.
Is there a meta/parent issue for that, or could we create one?
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
No issue just some discussion about the idea, see #3494222-7: Create a mirror for external library dependencies for composer support β . Another related issue is π Update external libraries Active .
- πΊπΈUnited States jrockowitz Brooklyn, NY
I believe most enhancements and improvements should be managed through dedicated contrib modules, and we can deprecate the webform rating element while recommending the new contrib rating element.
- πΊπΈUnited States luke.leber Pennsylvania
I'll have to look a bit closer but the star-rating.js library seems to be a bit susceptible to layout shifting.
Ideally, the markup for an element would be server-side rendered so there aren't any DOM reflows on the client side.
- πΊπΈUnited States luke.leber Pennsylvania
Nevermind! It looks like SSR mode is an option!
- πΊπΈUnited States jrockowitz Brooklyn, NY
enhancements and improvements should be managed through dedicated contrib modules,
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.