Umami Home Page Missing Regions

I'm working on this.

---
Thanks to Code Enigma for sponsoring my time to work on this.

Hi @mgifford

Can you have a glance at this please?

The MR moves tabs/highlighted/content-top/etc all inside the <main> element. And then amends the CSS to target a new container I created inside this called - .main-content-area so that sidebars, etc continue to work.

However, I am not sure if it's best for us to move all those items inside <main> or if, perhaps, we should create a new <section> above <main> and place them in there instead.

Thanks very much!

---
Thanks to Code Enigma for sponsoring my time to work on this.

Fixed footer which was reported for me by Axe devtools.

Thanks @finnsky

I've made some amends to your fixes.

Moved the .footer class back to the <footer> element
Set .layout-footer class to use the CSS that was targetting .footer

I think this is looking pretty good now.

===
Thanks to Code Enigma for sponsoring my time to work on this.

Was hoping someone with better eyes would pick this one up.

But could the issue summary be updated to use the standard template. Like what regions are being fixed, how? (see its rearranging all the page.html.twig?)

May help the reviewer. If no one can get to it though I'll try and give it my best shot.

Issue summary updated, moving back to 'Needs review'.

---

Thanks to The Confident for sponsoring my time to work on this.

Not sure if I'm testing wrong but using Accessibility insight and Landmark navigation I'm not seeing any different with the MR applied or not?

Think I was able to see the change with Landmark navigation? But leaning more on the code changes and that moving everything into main /footer region appears correct.

Regular visual check nothing seemed to break. Going to say it's probably good.

small update regarding role=main, we can simplify/fix it while we're at it.

Appears functional test was a random failure, re-running it's all green

Feedback around the role removal has been addressed.

nod_ → closed merge request !8676

Committed d86a0ee and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.