- 🇮🇪Ireland markconroy
Let's move this to the theme system queue. Looks like it's relevant to Drupal rather than just Seven theme.
- First commit to issue fork.
- 🇮🇳India nayana_mvr
I have re-rolled the MR to D11 but there are UI issues as shown in below screenshot.
The class names
.input-groupand.input-group__textare not getting added in the expected elements when compared to the HTML structure shown in http://getbootstrap.com/components/#input-groups. Also, as per my understanding, input-group can only be used if the theme uses Bootstrap style (Please correct me if I'm wrong). In D11 Claro theme doesn't use Bootstrap but there are many contrib themes such as Radix, Bootstrap, etc which can be used to achieve this.I tried a different approach for the UI part where I could make the input field and search button inline to each other. Screenshot attached below.
Attaching both re-rolled patch and patch with new approach here.
This issue seems to be an old one. Currently in D11, there exists one filter functionality in module extend page so do we still need to work this issue? If not please close this ticket. Moving to Needs Review for feedback.
- 🇮🇳India nayana_mvr
Attaching few issue links which I referred while looking into this ticket. Please feel free to remove if it's not relevant.
- 🇺🇸United States smustgrave
Patches should be in MR
Also issue summary should use complete template.
- Merge request !98202160545: Create search component for module listing form. → (Open) created by Unnamed author
- 🇮🇳India nayana_mvr
Created MR with the new approach and updated IS with complete template. Please review.
- 🇮🇳India sagarmohite0031
Hello,
I have try to reproduced the issue on Drupal 11 but its looks fine for me.
The MR is applied successfully.Please check attachment-
- 🇺🇸United States smustgrave
I don't think the MR is accomplishing what is described. All it seems to be doing is changing the label and adding a submit button where not needed. Why do we need a submit button for something that is autosubmitting? Also issue summary contains suggestions as typing which does not appear to be working.
- 🇮🇪Ireland markconroy
The free text filter on the "Extend" page is not a search component.
Please do not work on that as part of this issue.
This issue is to standardise how search will look where search is actually used when it's a single input+button in Drupal 7.
I'm not even sure there are examples of this in Drupal 10/11 core at this stage.
The only thing I can find is this:
With all that being the case, I am going to close this issue. If someone disagrees, please open a new issue with very clear instructions on what you want to achieve.