CSS linting (stylelint): npx update-browserslist-db@latest

Just picking 1 change

[dir="rtl"] #drupal-off-canvas-wrapper .dropbutton-wrapper.dropbutton-single .dropbutton-action:first-child

Shouldn't this be

:dir(rtl) #drupal-off-canvas-wrapper .dropbutton-wrapper.dropbutton-single .dropbutton-action:first-child

TBH: I don't know, but much more important, these are all "automagically" made changes by yarn build:css after I did the update of canisuse.

So even if it is indeed better to make that change, and again, I really am not a FE-person, so I have no clue, I believe that would be something for a follow-up issue?
(And I'm not even really sure about that one either...)

Asked #frontend channel. My concern is the current position is only checking that child selector and not the top level dir attribute.

:dir(rtl) should work perfectly fine for us.

It's a CSS function that has been supported for quite a while.

https://developer.mozilla.org/en-US/docs/Web/CSS/:dir

My only question is the position of :dir() does that function only apply to that child selector or will it check that top level id dir=rtl?

From MDN

The :dir() pseudo-class uses only the semantic value of the directionality, i.e., the one defined in the document itself.

Looks like it's document-level.

in that case I have no objections.

Mirroring status of parent issue, which became critical.

Committed f39f923 and pushed to 11.x. Thanks!

Thanks @nod, do we want to backport this down to other branches?

spokje → closed merge request !10135

yes makes sense to backport to 10.4

Personally I think we might wanna backport this to 11.1.x, 10.5.x and 10.4.x
(Oh, the joy off multiple active main branches...)

I'll put MRs up for all three of them and let y'all decide.

spokje → changed the visibility of the branch 11.x to hidden.

So it already landed in 11.1.x, so making an MR for 10.5.x and am pretty hopeful this can be backported to 10.4.x easily.

spokje → closed merge request !10241

nice thanks

Well, the bump in 10.5.x has surprisingly little, as in none at all, effect on the CSS files in there.

Oops

nod_ → closed merge request !10242

Automatically closed - issue fixed for 2 weeks with no activity.