hook_entity_reference_selection_alter() is undocumented

I am working on this documentation

There's something wrong with your MR -- it's saying 1000+ changes!

Are you sure your branches are correct?

I'm extremely confused with the MR that I see related with this issue. So many commits... why?

As I understand we simply need to add something like this to lib/Drupal/Core/Entity/entity.api.php:

/**
 * Modify the list of available entity reference plugins.
 *
 * This hook may be used to modify plugin properties after they have been
 * specified by other modules.
 *
 * @param array $plugins
 *   An array of all the existing plugin definitions, passed by reference.
 *
 * @see \Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginManager
 */
function hook_entity_reference_selection_alter(array &$plugins) {
  // Remove a plugin.
  unset($plugins['broken']);
}

What am I missing?

> I'm extremely confused with the MR that I see related with this issue. So many commits... why?

That can happen when the target branch set on the MR and the actual parent branch of the MR branch are not the same.

I was working on this issue with nhojivar7 at DrupalCon Barcelona contribution's day.

The documentation seems complete and correct now, I will set this to Needs Review

Can 1 MR be closed or hidden.

Also may want to check usage as I don't see anything in core besides a test using this hook. Maybe it's not needed?

> Also may want to check usage as I don't see anything in core besides a test using this hook. Maybe it's not needed?

It's standard for all plugin managers to have an alter hook for the discovered plugin info.

isa.bel → changed the visibility of the branch document-hook_entity_reference_selection_alter to hidden.

isa.bel → changed the visibility of the branch document-hook_entity_reference_selection_alter to active.

isa.bel → changed the visibility of the branch 3453692-hookentityreferenceselectionalter-is-undocumented to hidden.

MR 1 hidden, but I can't close it

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I checked the PR and all the checks passed, therefore I'm changing this to needs review again.

LGTM!

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

It's not possible to run phpstan in this file

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The bot may be correct, MR is 1800 commits back

I imagine the bot is complaining there’s no return of void

This needs one small change, see the comment in the MR.

LGTM

quietone → closed merge request !8384

Committed to 11.2.x and 11.x

Thanks!

quietone → closed merge request !9634

Thanks! As a docs-only fix, can this be committed to the 10 branch too?