- Issue created by @pfrenssen
- Merge request !123Issue-3481021-drupal-calls-should: Added depedency injection to requested classes → (Open) created by divyansh.gupta
- 🇮🇳India divyansh.gupta Jaipur
@pfrenssen I have made changes in the classes requested and applied dependency injection and removed direct drupal calls and placed construct and create functions where ever needed and updated existing in some of them.
Please review this MR and let me know if there are any changes to be made from my side. - 🇧🇬Bulgaria pfrenssen Sofia
Awesome, thanks so much for working on this. I see there is a test failure, can you have a look? It looks like the introduction of the constructor in
WeeklyRecurringDateWidget
needs to be adapted to match the parent class. - 🇮🇳India divyansh.gupta Jaipur
ok I will make the changes accordingly and make the test pass.
- 🇮🇳India divyansh.gupta Jaipur
I removed the test failure which was due to mismatch of create function with its parent class.
Please review it and tell me if any changes are to be made - 🇧🇬Bulgaria pfrenssen Sofia
Thanks for the work so far! I did an initial review, I found a few small issues.
- 🇮🇳India kulpratap2002
There are still some direct Drupal calls visible in the PHPStan pipeline.
- Status changed to Needs review
7 months ago 7:59am 17 December 2024 - 🇮🇳India ankitv18
Please fix the phpunit pipeline, also there are many warnings in the phpstan which needs to be taken care see: https://git.drupalcode.org/issue/recurring_events-3481021/-/jobs/3724042...
Method Drupal\recurring_events\Form\EventSeriesRevisionRevertForm::__construct() invoked with 2 parameters, 3 required.
- First commit to issue fork.
- Merge request !157Issue #3481021: \Drupal calls should be avoided in classes, use dependency injection instead → (Merged) created by plopesc
- Status changed to Needs work
15 days ago 5:49am 18 June 2025 - 🇪🇸Spain plopesc Valladolid
MR replacing \Drupal calls reported by PHPStan (Remaining ones in PHP classes should still be there).
While I was there, fixed the outstanding PHPStan issues, so PHPStan pipeline is green now as well!