- Issue created by @mstrelan
- First commit to issue fork.
- Merge request !12642Issue #3534371: Replace function_exists with method_exists for system_test_help → (Open) created by Unnamed author
- 🇦🇺Australia mstrelan
OK that test fail suggests this might not be a novice issue. IIRC there is another issue for ignoring hooks from modules that are not installed. This might be a duplicate of that.
- First commit to issue fork.
- 🇮🇳India sijumpk
From the code context, it seems like the usage of that assert is to confirm system_test module is not installed. If there is an issue with checking hooks, then we can do the same assertion using module_handler's moduleExists function. Plz review the code.
- 🇺🇸United States smustgrave
Summary doesn't appear to match the MR. Should check the issue the assert was added to see what the goal was.
- 🇦🇺Australia mstrelan
The assertion was added in #2160091-61: drupal_rebuild() rebuilds container twice, since drupal_flush_all_caches() also rebuilds it → (specifically comment #61). Have not reviewed closely, just identifying where it happened.
- 🇦🇺Australia mstrelan
I guess since Hooks classes are now autoloaded unconditionally it doesn't make sense to check if a method exists. I've updated the test to check if the hook implementation exists instead.