Hamburg
Account created on 16 March 2010, about 15 years ago
#

Merge Requests

Recent comments

🇩🇪Germany D34dMan Hamburg

Moving to different project as it occurs due to corrupted data being stored by "Drupal Project Management App"

🇩🇪Germany D34dMan Hamburg

Fixed in 1.4.3.

Crop definition generated prior to 1.4.3 via RIFT UI has to be fixed manually. This can be done by editing the crop type and changing the "Aspect Ratio" value to use ":" instead of "x" in their value.

🇩🇪Germany D34dMan Hamburg

The following code $this->themeHandler->getThemeDirectories(); in a Plugin manager is calling \Drupal::service('config.factory')->get('core.extension') somewhere down the lane. This apparently is resulting in circular dependency error.

I have not yet figured out how the circular dependency is getting generator. However, doing something like $a = \Drupal::service('config.factory')->get('core.extension'); in https://git.drupalcode.org/project/string/-/blob/1.0.x/src/StringManager... results in this error.

Not sure what is happening here.

🇩🇪Germany D34dMan Hamburg

Nice idea. This should help us start on a common ground to transliterate into other languages.

Some information I collected from internet regarding this topic,

English IPA for "Drupal"
Source https://en.wikipedia.org/wiki/Drupal

/ˈdruːpəl/

d as in "d"ye
r as in "r"ye
uː as in g"oo"se
p as in "p"ie
əl as in bott"le"

Dutch IPA for "Druppel" from which the word "Drupal" is inspired from
Source https://en.wiktionary.org/wiki/druppel

/ˈdrʏ.pəl/

d as in "d"one
r as in "r"est
ʏ as in n"u"t
p as in "p"uck
ə as in lab"e"l
l as in "l"ast

For Malayalam, I didn't find any IPA for "Drupal"
however in wikipedia it says "ദ്രുപാൽ"
Source: https://ml.wikipedia.org/wiki/%E0%B4%A6%E0%B5%8D%E0%B4%B0%E0%B5%81%E0%B4...

To note here,
In "ദ്രുപാൽ", the "പാ" (P) sound would rhyme with "PayPal".
"ദ്രു" (D) sound is a a dental one (and not a retroflux).

🇩🇪Germany D34dMan Hamburg

The work on performance improvement lead to a major code refactor, hopefully without breaking change.

The revisions are fetched via JavaScript so that the initial page can be rendered asap. The pagination introduced a problem in calculating parent revision. So did another refactor to detect parent revision via JavaScript after all revisions are fetched.

🇩🇪Germany D34dMan Hamburg

Hi @djdevin,

Thanks for showing interest.

The Graph Renderer library itself is a client side (JavaScript) library, so it should be possible to re-use the library to display workspaces_parallel in a separate tab.

I have documented the charting library here https://git.drupalcode.org/project/revision_graph/-/tree/3.x/revision-gr...

I don't know about the internals of workspaces_parallel, but am willing to collaborate on this. Could you please point me towards proper way to load the history of workspaces?

🇩🇪Germany D34dMan Hamburg

Removing misleading link to "Content Moderation is a new experimental module (2757719)" as it is not an experimental module anymore.

🇩🇪Germany D34dMan Hamburg

For those reviewing this project, please note that the development was performed by Anna. She is my colleague at Factorial GmbH. I created the project and published it on behalf of Anna so that it can be distributed.

The project's functional review was already performed during publication and the project is already in use.

🇩🇪Germany D34dMan Hamburg

Based on comment in #43 and #44 am going to put this on "needs work".

🇩🇪Germany D34dMan Hamburg

Marking this as closed won't fix as there is no plan to pursue this further.

🇩🇪Germany D34dMan Hamburg

Fix heading levels

🇩🇪Germany D34dMan Hamburg

Removed features overview

🇩🇪Germany D34dMan Hamburg

@ghost of drupal past,

I am afraid, we are increasing the scope of the fix.

As far as the scope of this bug report is about, it feels removing the hardcoded condition for "$this->count == 1" should be enough. Trying to find a sane default for cases under following scenario should be followed up in a separate issue (or issues),

- Case A: Translation data is corrupted, i.e. Message array doesn't contain the string at a particular index.
- Case B: Translation index formula can be wrong because of using default plural formula for language where it doesn't make sense.
- Case C: Translation index formula can be wrong due to corrupted Plural Form header in the PO file.

The main source of above scenario would be content/configuration done by User. And as pointed out in comment #8, the outcome has too many variations to handle.

As reported in this issue, despite having configured messages and Plural Formula correctly, Drupal Core fails to use the correct index, and hence that needs fixing.

🇩🇪Germany D34dMan Hamburg

@bceyssens thanks a lot! very much appreciated.

🇩🇪Germany D34dMan Hamburg

I am happy to write some test, but would like to clarify few things,

Question A:
Am not sure about core policy regarding test, I think we would need a kernel test for this one, Is that assumption correct?

Question B:
I see testing this is tricky. This refactor touches part which needs locale module to be enabled and configured in a certain way. So should this test be part of Locale Module testing scope? i.e. test be written under namespace Drupal\KernelTests\Core\Locale instead of Drupal\KernelTests\Core\StringTranslation

🇩🇪Germany D34dMan Hamburg

The rule has been applied based on the one from https://php-gettext.github.io/Languages/, which doesn't seems to match the rule used in POEdit

🇩🇪Germany D34dMan Hamburg

It seems to me the following simplification can be made as a step forward:

I have updated the MR with suggested changes.

>... precomputing 0-199

@ghost of drupal past, so we have a bug due to what seems to be a performance optimization. Thanks for the issues links which are quite helpful.

---

P.S. It seems like some comment/s are vanishing, like ghost comments! Is it Drupal.Orgs way of keeping discussion between a dead guy and a ghost spooky ¯\_(ツ)_/¯

Production build 0.71.5 2024