- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 1:48am 19 August 2023 - 🇳🇿New Zealand quietone
The suggested changes does not read well with me and one on-line grammer checked changed it. Since the other two sentences are about leadership are positive statements, I think this one should also be positive.
I have restored the change from #14,
Leadership is independent of having the greatest knowledge of software or technical skills.
. There was a comment that 'of' is not correct and that 'from' should be used. The information in the following links support 'of' - 🇺🇸United States xjm
Even with "from" the sentence is still very awkward with the auxiliary gerund and so forth. It's still hard to understand. I think this is an over-application of "make a positive statement". #17 was much clearer.
FWIW I have issues with the whole paragraph also. Like "great leaders" sounds kind of... elitist? Fascist?
Also the bit about "putting the project first" is unhealthy, compelling people to put the project above their own needs, and also has a whiff of the privilege-blind assumption that people are even able to always prioritize the project. People should always put their own health and needs first, and we should respect that maintainers have other commitments in their lives and are human beings with needs.
If we're going to keep this sort of as-is, I would use the language in #17.
Scope is no longer novice so untagging.
Also the MR doesn't actually seem cleanly rebased on main? Or GitLab's UI and the lack of an MR button on-issue here is again causing me confusion. I was going to say my usual thing to the novices about not mixing patches and MRs, but in this case there's a barrier to use an MR since the UI has no button to open an MR for the fork and the GL UI is several non-obvious steps.
- @quietone opened merge request.
- @quietone opened merge request.
- 🇳🇿New Zealand quietone
I followed the instructions on d.o for rebasing and it completed wrecked the existing branch. So I created a new one. That was weird too because the options to create the branch from does not include 'main' and the 'master' is behind 'main'.
There is a new MR with the suggested language from #24.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
@quietone It seems drupal.org does not correctly handle a main branch, yet. (That is probably the reason why Drupal core does not have a main branch.)
Should not the issue summary be updated? Title and issue summary still describe as "awkward" having also in a sentence, while the done change is different.
- 🇦🇺Australia pameeela
I agree this is an improvement, the sentence is awkward. I also updated the IS.