- Issue created by @ruslan piskarov
- Merge request !4Issue #3380676: Allows altering a user during importing β (Open) created by ruslan piskarov
- Status changed to Needs review
over 1 year ago 11:39am 11 August 2023 - Status changed to Needs work
over 1 year ago 12:21pm 13 August 2023 - π³π΄Norway gisle Norway
I want this module to be as simple as possible, so I will not promise to add this feature. I'll make up my mind when/if it reaches RTBC.
However, the MR does not update the README.md to inform about the existence of this hook. That need to be added.
- Status changed to Needs review
over 1 year ago 12:09pm 14 August 2023 - First commit to issue fork.
- π¬π§United Kingdom nicholasthompson
I've fixed the merge conflict on the merge request, however I have a thought... This isn't really an "alter"... its more of a "post_save" hook. If this was an alter, it should really run on the `$values` before line 193.
I have a case where I need to inject additional config so that when the user is created, some behavior can be altered (eg exporting to a 3rd party). This is something that needs to be set on the user object before its sent to be saved.
- πΊπ¦Ukraine ruslan piskarov Kyiv, Ukraine
@nicholasThompson, after your commit I see the following:
- Installing drupal/user_csv_import (2.0.3): Extracting archive
- Applying patches for drupal/user_csv_import
https://git.drupalcode.org/project/user_csv_import/-/merge_requests/4.diff (3380676: Allows altering a user during importing)
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/user_csv_import/-/merge_requests/4.diff - π¬π§United Kingdom nicholasthompson
@Ruslan - are you applying it to the tagged release or the dev branch?
as far as I'm aware, patches and MR's should be based against the dev branch, not the most recent tag.
- πΊπ¦Ukraine ruslan piskarov Kyiv, Ukraine
Sorry. For dev branch works well.