- Issue created by @sebastian.langierowicz
Hi Sebastian, I am getting the same issue in Drupal 10.5.0. It looks like the file ckeditor_media_resize/js/ckeditor5_plugins/mediaResize/src/mediaresizebuttons.js is importing icons from 'ckeditor5/src/core' and this export does not exist. Thanks.
- 🇺🇦Ukraine ruslan piskarov Kyiv, Ukraine
Not sure, nut maybe related https://www.drupal.org/node/3528806 → .
- First commit to issue fork.
- 🇬🇧United Kingdom scott_euser
Thanks for the tip Ruslan, was exactly that!
- Going to mark as major as there is no valid workaround except either locking to old version of core or disabling the module
- Added more detail to the issue summary + remaining issues (ie, deciding on whether a 2.x release of this module is needed - I expect that <=10.4 and <=11.1 both get broken by this, so 1.x may need to be locked to older Drupal Core and 2.x newer Drupal Core
- Updated title to help people find this a bit easier as I am not sure people will know the root cause is the Drupal Core underlying CKE version update
- 🇺🇸United States damienmckenna NH, USA
This resolves the problem with 10.5.0.
I think we should create a new minor branch (1.1.x) for this fix, then update 1.0.x to limit its compatibility to <10.5 and <11.2, then the new 1.1.x branch requires 10.5 or 11.2.
- 🇬🇧United Kingdom scott_euser
Branching strategy sounds good. And thanks for reviewing!
- 🇯🇴Jordan Rajab Natshah Jordan
Attached a static ckeditor_media_resize--2025-06-28--3531299--mr-16.patch file, for this point of MR16.
To be used with Composer Patches. - 🇺🇸United States davedg629
I can't get the patch in #11 to apply while also applying the patch from this issue: https://www.drupal.org/project/ckeditor_media_resize/issues/3401311 ✨ Possible for this module to work without "limit allowed HTML tags and correct faulty HTML" ? Active .
- 🇵🇱Poland lamp5 Rzeszow
HI @davedg629, the problem is with build so after you applied the patch, you need to rebuild a module and then your conflict will be resolved. Attached the patch that can be applied after:
https://www.drupal.org/files/issues/2024-10-03/3401311_no_html_filter_required.patch
from ✨ Possible for this module to work without "limit allowed HTML tags and correct faulty HTML" ? Active - 🇳🇿New Zealand ericgsmith
Change works and fixes the bug - just a minor in that most of the plugins I've seen have moved to using what is exposed by the icon plugin rather than directly referencing the icon path. Its a minor, but it could potentially save effort in the future if the icons are moved around within the plugin.
- 🇬🇧United Kingdom scott_euser
Sure go for it, sounds good IMO. As long as it still fixes the issue if that's what the documentation recommends... Thanks!
- 🇳🇿New Zealand ericgsmith
Made the following changes
- Bumped the Ckeditor version requirement in package.json to match the version of core 10.5.x / 11.2.x
- Bumped the Drupal core version requirement in the info file to ^10.5 / ^11.2
- Import from the publicly exposed constants instead of the source filesSorry for knocking it back to needs review from RTBC - have tested on a project and is still working for me
- 🇺🇸United States tderego Starkville, MS
MR!16 tested in Drupal 11.2.2, works great!
- 🇩🇪Germany florianboehme Koblenz, 🇩🇪
MR!16 tested in 10.5.1 and works. But the image has no size?
- 🇩🇪Germany Anybody Porta Westfalica
Any chance to merge this and tag a new release because of the "Major" status (broken projects)?
Thanks! - 🇩🇪Germany Anybody Porta Westfalica
Static patch from MR!22 current state attached
- 🇮🇳India roshanibhangale
Hi
I have tested this on drupal 10 and 11.x and followed the below steps:
Steps to reproduce
- Enable CKEditor Media Resize plugin in Drupal Core 10.5.x or 11.x
- Attempt to load CK Editor
- Editor fails to load with console errors
After applying patch successfully, observed that on editor load no error is displayed. Also while resize the image no error is presnet in console.
Hence this can be moved to RTBC+1. Attaching the screenshot for the reference