- Issue created by @ericgsmith
- π³πΏNew Zealand ericgsmith
Alright, got that pesky button working.
Bit of a shame the core version requirement has to be bumped - maybe there is a clever way to do this as a shim to keep support for both. Either way, this should be working now.
- πΊπΈUnited States RichardDavies Portland, Oregon
I can't get this patch to apply. Am I doing something wrong?
- πΊπΈUnited States mortona2k Seattle
The problem is that the Drupal.org packaging script info is in the actual repo file (should only be added when installed by composer).
https://git.drupalcode.org/project/edit_media_modal/-/blob/2.x/edit_medi...
That needs to be removed separately, it's conflicting with this MR.
Here is a patch that doesn't have that change.
- πΊπΈUnited States RichardDavies Portland, Oregon
Thanks, patch in #6 works for me.
- π³πΏNew Zealand ericgsmith
Yeah, unrelated to this MR but as I was changing the info file I saw and removed it on instinct - it would be good to remove it separately.
I'll rebase this MR and drop that commit.
Re patch - you can also reference just the commit that has the compiled plugin instead of the whole MR - https://git.drupalcode.org/issue/edit_media_modal-3531671/-/commit/12a9b...