[drupalImage] Setting to still allow linking to an image by URL even when uploads are enabled

Created on 23 June 2015, about 9 years ago
Updated 19 April 2024, 2 months ago

In #1932652: Add image uploading to WYSIWYGs through editor.module , we added the ability to upload an image directly into CKEditor. While great, this has the side-effect of making it impossible to insert just a raw src attribute into the dialog for inserting an image. There could be lots of reasons for using a raw src instead of uploading an image:

- The user only has the URL to a managed file (e.g. right-clicked on an image and used "Copy image URL")
- The image is a theme-level or manually uploaded asset outside of Drupal.
- The image is hosted on another site (for better or worse).

Long-term, it may be best to fold this into an issue where multiple ways of selecting images are possible: e.g. Upload, URL, Media Browser, etc.

Feature request
Status

Active

Version

11.0 🔥

Component
CKEditor 5 

Last updated about 4 hours ago

Created by

🇺🇸United States quicksketch

Live updates comments and jobs are added and updated live.
  • Needs product manager review

    It is used to alert the product manager core committer(s) that an issue represents a significant new feature, UI change, or change to the "user experience" of Drupal, and their signoff is needed. If an issue significantly affects the usability of Drupal, use Needs usability review instead (see the governance policy draft for more information).

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

    At this point, this feels more like a feature request than a bug

  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    EditorImageDialog is no more since 📌 [11.x] Remove EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 11 Fixed .

    But we could make this work for CKEditor 5. See #3222756-15: Allow using images from external source .

    In #22 I postponed this on 🐛 drupalimage CKEditor plugin should not require data-entity-uuid and data-entity-type when image upload is disabled Needs work . But that same bug fortunately does not exist for CKEditor 5 — we didn't port that bug 😄

    Agreed that this is a feature request, not a bug. And it's not major given that >10 years of CKEditor in Drupal has only resulted in 25 followers for this issue.

  • Status changed to Closed: outdated 4 months ago
  • 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺

    But … is this truly worth doing? "Hotlinking" external images is problematic: the URLs may stop working, and/or the image at that URL might change.

    Quoting the original reasons by @quicksketch:

    - The user only has the URL to a managed file (e.g. right-clicked on an image and used "Copy image URL")
    - The image is a theme-level or manually uploaded asset outside of Drupal.
    - The image is hosted on another site (for better or worse).

    Long-term, it may be best to fold this into an issue where multiple ways of selecting images are possible: e.g. Upload, URL, Media Browser, etc.

    1. Media + Media Library in core combined with the CKEditor 5 integration have solved that since then
    2. Linking to theme-level assets seems very edge-casey. External assets ("Digital Asset Management" systems or "DAMs") are common but … they are nowadays typically integrated with Drupal's Media Library 🥳
    3. This is the only reason to do this. But then there's security reasons to not do that: it's always safer to download and upload it to this site itself.

    So I'm going to be bold and close this issue. It didn't materialize for nearly a decade. There's been little demand from the community. And since then, we've gained Media Library in core, and a neatly integrated CKEditor 5 media embedding experience. I think the considerations that went into this in 2015 would be very different today, so the relevance of this issue has diminished.

    If anybody disagrees: feel free to reopen! 😊

  • Status changed to Active 2 months ago
  • 🇹🇭Thailand manarak

    re-opened.
    see https://www.drupal.org/project/drupal/issues/3439275#comment-15558438 [drupalImage] only UPLOAD or LINKING possible, not both Closed: duplicate

Production build 0.69.0 2024