- 🇨🇭Switzerland gagarine
"Let's overengineering" is the tagline of Drupal.
- Merge request !6969Resolve #2893568 "Ckeditor5 link default protocol" → (Closed) created by wim leers
- Status changed to Needs review
11 months ago 10:13am 8 March 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Definitively outdated since 📌 [11.x] Remove EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 11 Fixed .
But … also still an issue with CKEditor 5. I just tried it and was able to reproduce the same problem.
Fortunately, they have infrastructure in place that makes it easy to achieve this: https://ckeditor.com/docs/ckeditor5/latest/features/link.html#adding-def...
This is so absurdly low-hanging fruit that I immediately created a merge request and screencast for it. It's 2 lines of code. IMHO it doesn't even need tests, because the CKEditor 5 team obviously is testing this already.
- Status changed to RTBC
11 months ago 2:37pm 8 March 2024 - 🇺🇸United States AaronBauman Philadelphia
That's great, thanks for the MR.
Surprised ckeditor doesn't have a default value in the first place, and agree that it would be silly to add test coverage for a 3rd party library.Anyone know if there's a similar issue open for the link widget already?
That's another super annoying UX / validation constraint when protocol is missing. - Status changed to Fixed
11 months ago 11:14pm 18 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.