Provide a block for running cron from a dashboard

The block itself might need tests.

1. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   + * Provides a block to display 'Site branding' elements.
   

   Fix comment.

2. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   + *   forms = {
   + *     "settings_tray" = "Drupal\system\Form\SystemBrandingOffCanvasForm",
   + *   },
   

   This needs to be removed.

3. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   +    $cron_last = \Drupal::state()->get('system.cron_last');
   ...
   +      $cron_last = \Drupal::state()->get('install_time', 0);
   

   Inject state?

4. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   +    $request_time = \Drupal::time()->getRequestTime();
   

   Inject time()?

5. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   +    $summary = t('Last run @time ago', ['@time' => \Drupal::service('date.formatter')->formatTimeDiffSince($cron_last)]);
   

   Inject date.formatter?

6. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   +    $x['cron'] = [
   

   This needs to be $data, or to be removed.

7. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   +        '#title' => t('more information'),
   ...
   +        '#title' => t('Run cron'),
   

   We need StringTranslationTrait and $this->t()

8. +++ b/core/modules/system/src/Plugin/Block/CronStatusBlock.php
   @@ -0,0 +1,159 @@
   +    return Cache::mergeTags(
   +      parent::getCacheTags(),
   +      $this->configFactory->get('system.cron')->getCacheTags()
   +    );
   

   We need CacheableMetadata->createFrom() to ensure we don't leave anything behind.

Discussed with @lauriii. Splitting the big status report template into smaller pieces it's useful no matter what happens with dashboards. They eventually might become sdc components. So it makes sense to propose that change in core already.

On second thoughts, we agreed that it's not that important atm, and we can avoid that for now. Probably by the time we plan to integrate this that might have been converted to SDC already.

Update status.

Tested this out by manually verifying the block appears in the block layout list
Placed the block at the top of the content region.
Verified it worked as expect

CR reads well.

Double checked in CronForm whether it includes the cron status/last stufff, and it does. This looks good to me.

Added some comments to the MR.

Thank you for your review @alexpott.

Addressed the comments MR.

Moving it back to Needs Review.

Feedback appears to be addressed.

🌱 Enhance user experience with customizable dashboards Active is still waiting for product manager approval, and this block will only make sense with that, so tagging for product managers.