🇩🇪Germany @dercheffe

dercheffe → created an issue.

dercheffe → created an issue.

Why is this closed as "works as designed"?

IMO it would be a massive UX improvement.

I'm also interested.

dercheffe → created an issue.

Merge request 106 worked. As Berdir wrote, it's only working, if you apply the patch before upgrading from groups V1 to V2. Perhaps it's possible to re-trigger the db actions as part of the patch again?

dercheffe → created an issue.

Ok, did another test run with my local installation here.
My starting point:

• Desktop environment: Ubuntu Linux 23.10 with Firefox 119
• Local dev environment: DDEV with PHP 8.1
• Entity embed dev version with no patch applied
• Drupal 9.5 with ckeditor 5 enabled
• Contributed ckeditor 4 module (still) enabled

What I did next:

1. Switching all ckeditor 4 text fomats to ckeditor 5 (taking care about screen messages from upgrade path)
2. Deinstalling ckeditor 4 contrib module with drush and composer

Result: Now the markup was messed up like in my comment #31 and shown in a normal textarea-field. Ckeditor didn't render.

Then I performed upgrade from D9.5 to D10.1 with composer and "drush updb".

Result: Now ckedior worked probably
Result 2: The creation of new content worked like a charm too.

Conclusion:
I suggest to make a new (alpha/beta/stable ?) release of the current dev version. Perhaps a new branch making sense due to ckeditor 5 compatibility.

After upgrade to D10.1 with this test installation it renders correctly now suddenly without the patch 😳
Its very weird.

But would it harm to include the patch anyway?

This is my non-rendering markup code with following configuration:

• PHP 8.1
• Entity embed dev version with no patch applied
• Drupal 9.5 with ckeditor 5 enabled

<p>Krankenhäuser haben Betten und Betten benötigen Matratzen. Nur gut wenn man unter den TheMall - Partnern auch einen Hersteller für medizinische und Dekubitus - Matratzen hat.</p>&#13;
&#13;
<p>Auf eine dringende Anfrage aus der Ukraine konnten wir sofort die nötigen Hebel in Bewegung setzen und die <a href="https://youlife.rocks/the-mall/mall-shop/breckle-matratzenwerk-weida-gmbh">Breckle Matratzenwerk Weida GmbH</a> fertigte für uns 10 Matratzen mit Schutzbezügen für den klinischen Bereich. Diese wurde innerhalb kürzester Zeit im Outlet-Store der Firma in Benningen angeliefert. Dort nahm sie unser Robert von der Firma <a href="https://speidel.net/unternehmen-2/">Speidel GmbH</a> in Empfang, um diese direkt zur <a href="https://www.skp-gmbh.com/de/Startseite.1.html">SKP GmbH</a> in Mühlacker zu bringen. SKP fertigt Reinigungsanlagen für Zeltplanen und hatte eine große Maschine im Versand. Unsere Matrazen wurden direkt an den LKW geliefert und verließen noch am selben Tag zusammen mit weiteren Spenden Mühlacker in Richtung Zwischenlager Polen.</p>&#13;
&#13;
<drupal-entity data-caption="Freuen sich helfen zu können: SKP Juniorchefin Anna Segiet und Robert Iglewski von Speidel" data-embed-button="embed_erlebnis_magazin_media" data-entity-embed-display="view_mode:media.yl_hero_image" data-entity-embed-display-settings="" data-entity-type="media" data-entity-uuid="0aab16e4-0755-42d1-8807-b00a18237097" data-langcode="de"></drupal-entity><p>Es ist wirklich grandios, was alles möglich ist. Unser Dank gilt allen beteiligten Firmen, sowie der <a href="https://muehlacker-enzkreis.rotary.de/">Rotary Hilfe e.V. Mühlacker-Enzkreis</a> für Ihre Unterstützung.</p>&#13;
&#13;
<p>Ihr wollt auch unterstützen und sicher sein, daß die Hilfe richtig ankommt?</p>&#13;

Tested from several people - so we can change the issue status? 🙂

Get a same/similar error when a user wants to join into a group. Even when I apply the MR of #12 as patch.

The website encountered an unexpected error. Please try again later.
TypeError: call_user_func(): Argument #1 ($callback) must be a valid callback, class "Drupal\group\Entity\GroupContent" not found in call_user_func() (line 400 of core/lib/Drupal/Core/Field/FieldConfigBase.php).

call_user_func('Drupal\group\Entity\GroupContent::getDefaultEntityOwner', Object, Object) (Line: 400)
Drupal\Core\Field\FieldConfigBase->getDefaultValue(Object) (Line: 169)
Drupal\Core\Field\FieldItemList->applyDefaultValue() (Line: 271)
Drupal\Core\Entity\ContentEntityStorageBase->initFieldValues(Object, Array) (Line: 129)
Drupal\Core\Entity\ContentEntityStorageBase->doCreate(Array) (Line: 94)
Drupal\Core\Entity\ContentEntityStorageBase->create(Array) (Line: 156)
Drupal\group\Entity\Storage\GroupRelationshipStorage->createForEntityInGroup(Object, Object, 'group_membership') (Line: 75)
Drupal\group\Controller\GroupMembershipController->join(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Possible to get a new stable release of entity_embed with with the MR included 🙏? It's a real release blocker for me and the EOL of D9.5 is here (and I'm still on CKEditor 4 because of this issue 🙈)

Using the MR https://git.drupalcode.org/project/entity_embed/-/merge_requests/26 as a patch on the latest dev of entity_embed on D9.5. It solves the issue and the editor renders great! thank you @bnjmnm

I lift up this issue to critical, because it's crashing site rendering with a Fatal PHP error when rate widgets are used on a page.

I can confirm patch in #22 solves the problem. Thank you for it :) @Maintainers please make a new release to address it.

It's up to the developers and UI / UX designers to create an accessible interface regardless of whether the orientation is locked or not. IMHO Drupal shouldn't go against the manifest specs. If an option is available in the specs and supported by most browsers, even if not mandatory, it should be configurable.
If you don't want to lock the orientation change, you would choose the "any" option (which should be the default option since it will be the case in 90% of the WPAs) but if - for some reason - you want to lock the orientation, Drupal should provide the means to do so.

As a disabled person I agree with that 👍. Going with the standards/specs of technology is almost a good option. Don't forget that accessibility often plays together with different third party apps. The assistance software (braille device etc.) is more comfy with standards. And in my opinion it might be a kind of exclusion too, to "hard code" an option independent from it's direction. Let the developers/designers decide what is necessary for the individual use case.

Upgrade to version 3 is not possible when follow instructions. Can confirm issue in #17. It breaks site completely when uninstalling recurring period module. IMO this is not fixed and also critical.

Is there a workaround to suspend/stop processing a queue until the issue is fixed?

All I want to achieve is following:

If a variable has value x then don't process the queue during cron. Tried to do this with a preprocess event listener but don't know how to stop the queue processing.

dercheffe → created an issue.

Thank you so much for the patch 🙏.

I tested it on my site installation. The default billing country is Germany (order summary is shown with VAT 19%).
I provide at my site two payment methods for the customer. Both payment methods are checked to collect billing information.
My payment methods provided:

• stripe (see Module page → ) for credit card payments
• "Buy on invoice", a manual payment plugin, which does actually nothing, aside collect billing information for generating an invoice later via commerce_invoice module → . The user can pay later, sending the money manually via bank transfer.

I have following results after applying the patch:

Let's say the user is from Austria (VAT 20%) instead Germany. The user is a first time customer, no customer profile yet.

Test with Stripe

After filling out billing information and click on "continue to review" the order summary gets refreshed with 20% VAT. Works fine.
From a UX point of view it would IMO be nicer, the summary gets refreshed immediately as soon as the billing country in the address widget is changed. AFAIK the address field does a AJAX update of itself too when country is changed?

Test with "manual" plugin

After filling out billing information and click on "continue to review" the order summary doesn't get refreshed. Here the patch doesn't work. The order gets only refreshed after waiting for refresh interval.

Trying to figure out if an ajax callback would be an option too. But no idea where to hook in and alter existing structures. commerce (sub)module has something similar functionality, when applying a coupon, then the order summary gets updated (and the order recalculated). See \Drupal\commerce_promotion\Plugin\views\area\CouponRedemption::ajaxRefreshSummary.

Is there a more generic solution than manipulate the billing information form? For example if you're using different forms depending on payment method (in my case commerce_stripe module). But I'm not sure how commerce_stripe gathers address information 🙈

Similar problem. I do not use currency resolver module. This is my error output:

TypeError: Drupal\commerce_cart\CartManager::removeOrderItem(): Argument #1 ($cart) must be of type Drupal\commerce_order\Entity\OrderInterface, null given, called in /var/www/html/MY-DRUPAL-SITE/web/modules/contrib/commerce/modules/cart/src/Plugin/views/field/RemoveButton.php on line 121 in Drupal\commerce_cart\CartManager->removeOrderItem() (Zeile 162 in /var/www/html/MY-DRUPAL-SITE/web/modules/contrib/commerce/modules/cart/src/CartManager.php)

#0 /var/www/html/MY-DRUPAL-SITE/web/modules/contrib/commerce/modules/cart/src/Plugin/views/field/RemoveButton.php(121): Drupal\commerce_cart\CartManager->removeOrderItem(NULL, Object(Drupal\commerce_order\Entity\OrderItem))
#1 /var/www/html/MY-DRUPAL-SITE/web/core/modules/views/src/Form/ViewsFormMainForm.php(183): Drupal\commerce_cart\Plugin\views\field\RemoveButton->viewsFormSubmit(Array, Object(Drupal\Core\Form\FormState))
#2 /var/www/html/MY-DRUPAL-SITE/web/core/modules/views/src/Form/ViewsForm.php(190): Drupal\views\Form\ViewsFormMainForm->submitForm(Array, Object(Drupal\Core\Form\FormState))
#3 [internal function]: Drupal\views\Form\ViewsForm->submitForm(Array, Object(Drupal\Core\Form\FormState))
#4 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Form/FormSubmitter.php(114): call_user_func_array(Array, Array)
#5 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Form/FormSubmitter.php(52): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object(Drupal\Core\Form\FormState))
#6 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(592): Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object(Drupal\Core\Form\FormState))
#7 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(320): Drupal\Core\Form\FormBuilder->processForm('views_form_comm...', Array, Object(Drupal\Core\Form\FormState))
#8 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Form/FormBuilder.php(219): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\views\Form\ViewsForm), Object(Drupal\Core\Form\FormState))
#9 /var/www/html/MY-DRUPAL-SITE/web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(2257): Drupal\Core\Form\FormBuilder->getForm(Object(Drupal\views\Form\ViewsForm), Object(Drupal\views\ViewExecutable), Array)
#10 [internal function]: Drupal\views\Plugin\views\display\DisplayPluginBase->elementPreRender(Array)
#11 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(101): call_user_func_array(Array, Array)
#12 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/Renderer.php(772): Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_ren...', 'exception', 'Drupal\\Core\\Ren...')
#13 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/Renderer.php(363): Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array)
#14 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/Renderer.php(435): Drupal\Core\Render\Renderer->doRender(Array)
#15 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/Renderer.php(435): Drupal\Core\Render\Renderer->doRender(Array)
#16 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/Renderer.php(201): Drupal\Core\Render\Renderer->doRender(Array, false)
#17 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(241): Drupal\Core\Render\Renderer->render(Array, false)
#18 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/Renderer.php(564): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
#19 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(242): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#20 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(132): Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
#21 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
#22 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#23 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(142): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#24 /var/www/html/MY-DRUPAL-SITE/vendor/symfony/http-kernel/HttpKernel.php(174): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view')
#25 /var/www/html/MY-DRUPAL-SITE/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#26 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /var/www/html/MY-DRUPAL-SITE/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /var/www/html/MY-DRUPAL-SITE/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /var/www/html/MY-DRUPAL-SITE/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /var/www/html/MY-DRUPAL-SITE/web/core/lib/Drupal/Core/DrupalKernel.php(709): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /var/www/html/MY-DRUPAL-SITE/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#35 {main}

Tried to do some debugging with xdebug:
In MY-DRUPAL-SITE/web/modules/contrib/commerce/modules/cart/src/Plugin/views/field/RemoveButton.php in line 120 the $order_item is fetched but the value of order_id is null.
That's why its caused the error in line 121.

Is there a workaround to solve this issue?

What I need is, how to natively create an email with this module directly. Wi

email_entity = $email_factory->newTypedEmail('MYMODULE', 'my_awsome_email_subtype');
$email_entity->setParam('user_display_name', $user_recipient_name);
$email_entity->setSender($email_from);
$email_entity->setSubject($email_subject);
$email_entity->setTextBody($email_body_plain);
$email_entity->setTo($user_recipient_email);
$operation_status = $email_entity->send();

Unfortunately it doesn't work.
I get "Call to a member function newTypedEmail() on null"🙈

Or how can I do the "native implementation" in the docs it's called "Level 3" correctly?

So would it be possible to stop queue processing when e.g. during my process() function a variable gets a specific value?
I want to achieve that a process only runs until e.g. 10 jobs in a queue are done successfully in one (cron) run. So I could use a kind of counter.

dercheffe → created an issue.