Lift all methods out of `SdcController` into separate invokable services-as-controllers

👍

(Added some extra context to the issue summary.)

Also if its ok with you can we go ahead and merge smaller MR's so that it becomes easier for you to review too.

+1

Just one last nit, then this first MR can land. I retitled the MR to convey that it's only addressing a subset of the scope.

📌 SdcController cleanup tasks Active identified that there are two unused routes. Those of coursedon't need to be lifted, they can just be removed. They are the routes with the paths /xb-render-component/{component_id} and /xb-component/{component_id}.

So the next MR on this issue should just remove those 2 routes.

I think this was only waiting on my weigh-in. Approved. 🙂 I don't know who should merge it.

Thanks, @traviscarden! Merged https://git.drupalcode.org/project/experience_builder/-/merge_requests/342, now back to for the remaining MRs that are needed.

MR !343 is now ready for review.

wim leers → changed the visibility of the branch 3477164-lift-all-methods to hidden.

Some tiny nits, then this will be done! 😄

I'd have landed this first, but it wasn't ready. 📌 [PP-1] HTTP API: update /xb-render-component/{component_id} to use Component config entity's default values Postponed has landed now, so this will need to be rebased.

This MR is failing tests. Hence it's not ready for review.

Turns out 0.x CI pipelines are failing too, due to disruptive upstream changes in Drupal core. Created issue to get 0.x passing tests again, after which this will be able to land: 📌 [upstream] Test expectations must be updated to match Drupal 10.4.0/11.1.0 changed behavior of (Dynamic) Page Cache response headers Active .

📌 [upstream] Test expectations must be updated to match Drupal 10.4.0/11.1.0 changed behavior of (Dynamic) Page Cache response headers Active landed.

So much cleaner and clearer! 🥳

Automatically closed - issue fixed for 2 weeks with no activity.