- Issue created by @wim leers
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
This blocks @bnjmnm over at š Add component instance edit form to contextual panel RTBC .
- Assigned to wim leers
- Status changed to Active
5 months ago 2:44pm 9 July 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
āØ Allow specifying default props values when opting an SDC in for XB Fixed is in.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
ā ļø Note that this won't fix the problem demonstrated in the issue summary's GIF for the component, because for that š [PP-1] Default props values should support files/images Postponed must first happen on the config management side.
- Merge request !83Resolve #3455942 "Api render component with default props values from config" ā (Closed) created by wim leers
- Assigned to bnjmnm
- Status changed to Needs review
5 months ago 3:00pm 9 July 2024 - First commit to issue fork.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Oops, sorry for overwriting your merging of upstream commits, @bnjmnm, that was unintentional š
- Assigned to wim leers
- Status changed to Postponed
5 months ago 2:25pm 26 July 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Working to get this issue's status/relevance updated, but blocked on @lauriii's confirmation at #3463999-7: [PP-1] Auto-generate Component config entities for all discovered SDCs that meet XB's minimum criteria ā .
- Assigned to f.mazeikis
- Status changed to Active
4 months ago 2:09pm 26 August 2024 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
This is no longer a blocker though.
š Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria Fixed is now in. Thanks to that issue, the following
if
-test is obsolete ā that is now a requirement for an SDC to become available in XB:// @todo Revisit in https://www.drupal.org/project/experience_builder/issues/3455942. if ((isset($prop_info['examples']) && isset($prop_info['examples'][0])) || in_array($prop_name, $metadata->schema['required'] ?? [])) {
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
I'll push this forward tomorrow. It's been lingering too long, and I'd like @f.mazeikis to remain focused on š Add support for Blocks as Components Active .
- Merge request !344#3455942: HTTP API: update /xb-components to use Component config entity's default values ā (Merged) created by wim leers
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Now properly ready for review! š
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
My title update was lost š¬
- š¬š§United Kingdom f.mazeikis Brighton
Re-ran pipeline and it's now passing. Code looks good too - certainly an improvement, even if we still need to come back to this once we have solutions for datetime and image (and entity references in general) props handling.
-
wim leers ā
committed 248b96a8 on 0.x
Issue #3455942 by wim leers, bnjmnm, f.mazeikis: HTTP API: update /xb-...
-
wim leers ā
committed 248b96a8 on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.