- Issue created by @jessebaker
- First commit to issue fork.
- First commit to issue fork.
- ๐บ๐ธUnited States hooroomoo
hooroomoo โ changed the visibility of the branch 3452512-edit-2 to hidden.
- ๐บ๐ธUnited States hooroomoo
Started on edit-3 branch which is off the most recent 0.x that has โจ [MR Only] Edit any component prop, powered by a new FieldForComponentSuggester service, which will power the JS UI Fixed . Didn't get very far yet, currently the branch is just rendering the values from field.feld..node.article.field_xb_demo which is hard-coded in layout-default.json. Not sure if there's an endpoint that exists yet that I can fetch the tree and props/model from.
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
See gitlab MR description for more details...
There isn't any ๐
- Assigned to hooroomoo
- ๐บ๐ธUnited States hooroomoo
hooroomoo โ changed the visibility of the branch 3452512-noop to hidden.
- Status changed to Needs work
17 days ago 9:00am 11 June 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
@hooroomoo shared a screenshot in Slack, attaching here:
๐ Unfortunately, I canโt get to that point locally โ maybe because of
$ npm run build > vite-template-redux@0.0.0 build > tsc && vite build nsrc/features/panel/ContextualPanel.tsx:30:35 - error TS7031: Binding element 'htmlString' implicitly has an 'any' type. 30 const BadHtmlParserComponent = ({ htmlString }) => { ~~~~~~~~~~ src/features/panel/ContextualPanel.tsx:43:62 - error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'. 43 const responseAsDocument = new DOMParser().parseFromString(response.data, 'text/html'); ~~~~~~~~~~~~~ Found 2 errors in the same file, starting at: src/features/panel/ContextualPanel.tsx:30 wim.leers at MacBookPro-WimLeers in ~/core/modules/contrib/experience_builder/ui on edit-3*
- ๐บ๐ธUnited States hooroomoo
Ah yeah I see there are TS errors that cause the build to fail. But if you run in development mode
npm run dev
you should be able to reproduce it. I will fix the build errors though. - ๐ซ๐ฎFinland lauriii Finland
We still need to wait for new endpoints to actually make changes to the backend so this is still in early stages.
What are the missing endpoints? Are there Drupal.org issues for these endpoints already? Can we link them here for clarity?
- ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
Updated IS with details of how the form is being generated.
- ๐บ๐ธUnited States hooroomoo
Current state it only has the text prop rendering right now:
- Status changed to Active
15 days ago 6:08pm 13 June 2024 - ๐บ๐ธUnited States hooroomoo
Radix tooltip that shows unique data to prove JSX-ified drupal form can be integrated with our frontend
- ๐บ๐ธUnited States hooroomoo
This is using Drupal's autocomplete behavior
- Status changed to Needs work
8 days ago 3:56pm 20 June 2024 - ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Marking for the remarks I posted.
Plus, @effulgentsia just requested that "undo" support works correctly even when the autocomplete is used โ that's indeed worth verifying that it works correctly.
After my remarks + @effulgentsia's is addressed, please assign this to @bnjmnm. When he gets back from PTO next week, I think he'd be the best person to extract pieces that can land today. No pieces that call/reuse
TwoTerribleTextAreasWidget
should land, and instead we should work on the next steps under in ๐ฑ [META] Early phase back-end work coordination Active . - Assigned to bnjmnm