- Issue created by @bnjmnm
- Status changed to Active
about 1 month ago 2:59pm 26 July 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
β¨ Contextual form values need to be integrated with Redux Active is in! π₯³
- Assigned to balintk
- ππΊHungary balintk
I'm picking this up as the continuation of π Values in props edit form do not always match the selected component Fixed .
- Merge request !180#3463618: Include component props form in undo β (Merged) created by Unnamed author
- Status changed to Needs review
19 days ago 7:17pm 19 August 2024 - Assigned to bnjmnm
- Status changed to RTBC
19 days ago 11:33am 20 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
@balintbrews indicated this should land after π Values in props edit form do not always match the selected component Fixed , so conveying that.
But it's also down to final review, and this area is definitely @bnjmnm's area of expertise (he introduced β¨ Contextual form values need to be integrated with Redux Active ), so let's get his final sign-off.
- Status changed to Needs work
18 days ago 12:59pm 20 August 2024 - ππΊHungary balintk
As @bnjmnm pointed out, we need some tests here which I completely forgot about. π€¦π» I'll work on those later today.
- Assigned to balintk
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
π Values in props edit form do not always match the selected component Fixed is in.
- Status changed to Needs review
17 days ago 12:10pm 22 August 2024 - Assigned to bnjmnm
- Issue was unassigned.
- Status changed to RTBC
12 days ago 6:09pm 26 August 2024 - πΊπΈUnited States bnjmnm Ann Arbor, MI
This seems good to go though if possible I recommend waiting on β¨ Implement simplified zoom interface Fixed to land then refactoring this a bit as the other way around might be more difficult and possibly require an additional issue.
- ππΊHungary balintk
Waiting for β¨ Implement simplified zoom interface Fixed to land as @bnjmnm suggested, then we can have an even cleaner end-to-end test.
- First commit to issue fork.
-
hooroomoo β
committed 628ca7d6 on 0.x authored by
balintbrews β
Issue #3463618 by balintbrews, bnjmnm, jessebaker: [PP-1] Include...
-
hooroomoo β
committed 628ca7d6 on 0.x authored by
balintbrews β
- Status changed to Fixed
11 days ago 9:05pm 27 August 2024