- Issue created by @lauriii
- Assigned to Gauravvv
- Merge request !116#3463307: Slider range created for zoom controls → (Merged) created by Unnamed author
- 🇮🇳India Gauravvv Delhi, India
Based on the image in the issue description, the range slider for zoom should not include additional values like X, and Y points or the "debug to scroll" button. Do I need to hide these in the current tray or create a new one for the range slider? Thank you.
- 🇫🇮Finland lauriii Finland
Could we add a "debug" prop to the component to show these things? In a future issue, we could consider toggling that based on an environment variable (or something else) but for now it could be something that developers would have to turn on manually within code.
- Issue was unassigned.
- Status changed to Needs review
about 1 month ago 3:34am 26 July 2024 - 🇮🇳India Gauravvv Delhi, India
I have added a prop debug, if it is true then it will display the X, Y coordinates and "Debug: scroll to middle" button and on debug false it will only display the zoom range slider.
Debug: false
Debug: True
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Those screenshots look great, @Gauravvvv! 🤩
Keeping at , but IMHO this should be integrated with
AppConfiguration
(introduced by #3452582) — see MR review. - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Merged in upstream, CI should be green again 👍
- 🇫🇮Finland lauriii Finland
This looks pretty nice! It would be super cool if we could slightly smoothen the transition when zooming. This can be a follow-up but could be worked on here too in case you're interested in this 😊
- 🇮🇳India Gauravvv Delhi, India
Addressed feedback on using
AppConfiguration
as well smoothen the transition when zooming - 🇮🇳India Gauravvv Delhi, India
Gauravvvv → changed the visibility of the branch 3463307-zoom-interface to hidden.
- 🇮🇳India Gauravvv Delhi, India
Gauravvvv → changed the visibility of the branch 3463307-zoom-interface to active.
- Status changed to Needs work
about 1 month ago 1:06pm 31 July 2024 - Assigned to Gauravvv
- Issue was unassigned.
- Status changed to Needs review
about 1 month ago 2:02pm 2 August 2024 - Status changed to Needs work
about 1 month ago 3:05pm 2 August 2024 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Still not passing tests … 😅 why are you marking this ? 🤔
- 🇮🇳India Gauravvv Delhi, India
Hi @Wim Leers, I changed the status to needs review before the test results.
- First commit to issue fork.
- Assigned to jessebaker
- Status changed to Active
20 days ago 10:17am 19 August 2024 - Assigned to bnjmnm
- Status changed to Needs review
19 days ago 12:10pm 20 August 2024 - 🇬🇧United Kingdom jessebaker
This is now ready for review. I picked up from the work by @gauravvvv and implemented the suggestion from @lauriii in #10. Zoom controls now exist in their own React component and an array of tests have been added (and the existing tests cleaned up as a result of me getting absolutely stuck on a weird race condition that seemingly was nothing to do with this issue!)
- Issue was unassigned.
- Status changed to Needs work
17 days ago 6:23pm 21 August 2024 - 🇺🇸United States bnjmnm Ann Arbor, MI
Looking good - got some nits and bits in the MR that I'm sure can be addressed pretty easily.
- Assigned to Gauravvv
- Assigned to bnjmnm
- Status changed to Needs review
17 days ago 12:17pm 22 August 2024 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Awesome progress here! 👏
Can we get an updated GIF in the issue summary to showcase that awesomeness? 🙏😇
Also: AFAICT this is ready for review! 😄
- 🇭🇺Hungary balintk
Just adding a comment here to note that there is some testing code added in ✨ Include component props form in undo Needs review (commit in MR: 5aa96e) which should be updated once this issue lands and we have the `loadURLandWaitForXBLoaded` command available.
- First commit to issue fork.
- Status changed to Needs work
12 days ago 5:19pm 26 August 2024 - Issue was unassigned.
- 🇺🇸United States hooroomoo
Removed the debugging controls from the PoC and updated the IS accordingly. I don't think there is really a need for them right now and we can easily add them back if that changes in the future.
- Assigned to bnjmnm
- Status changed to Needs review
12 days ago 7:05pm 26 August 2024 -
bnjmnm →
committed bd8ee98e on 0.x authored by
gauravvvv →
Issue #3463307 by jessebaker, gauravvvv, Wim Leers, bnjmnm: Implement...
-
bnjmnm →
committed bd8ee98e on 0.x authored by
gauravvvv →
- Issue was unassigned.
- Status changed to Fixed
11 days ago 4:21pm 27 August 2024