Implement simplified zoom interface

Created on 23 July 2024, 5 months ago
Updated 11 September 2024, 3 months ago

Overview

The zoom interface has controls for debugging the zoom which was added as part of the PoC. There's now a designed version of this interface ready to be implemented. This issue will also remove the debugging controls that were from the PoC.

Note: there's another issue for improving the mouse panning: 🐛 Middle click + drag doesn't work correctly if middle click is inside preview iframe Active .

Proposed resolution

Implement the simplified zoom interface.

User interface changes

Smooth zoom with pinch and using the slider!

Feature request
Status

Fixed

Component

Page builder

Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @lauriii
  • Assigned to gauravvvv
  • 🇮🇳India gauravvvv Delhi, India
  • Pipeline finished with Failed
    5 months ago
    Total: 193s
    #232659
  • 🇮🇳India gauravvvv Delhi, India

    Based on the image in the issue description, the range slider for zoom should not include additional values like X, and Y points or the "debug to scroll" button. Do I need to hide these in the current tray or create a new one for the range slider? Thank you.

  • 🇫🇮Finland lauriii Finland

    Could we add a "debug" prop to the component to show these things? In a future issue, we could consider toggling that based on an environment variable (or something else) but for now it could be something that developers would have to turn on manually within code.

  • Pipeline finished with Failed
    5 months ago
    Total: 194s
    #233556
  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • 🇮🇳India gauravvvv Delhi, India
  • Pipeline finished with Failed
    5 months ago
    Total: 308s
    #234372
  • 🇮🇳India gauravvvv Delhi, India

    I have added a prop debug, if it is true then it will display the X, Y coordinates and "Debug: scroll to middle" button and on debug false it will only display the zoom range slider.

    Debug: false

    Debug: True

  • Pipeline finished with Failed
    5 months ago
    Total: 381s
    #234375
  • Pipeline finished with Failed
    5 months ago
    Total: 192s
    #234379
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Those screenshots look great, @Gauravvvv! 🤩

    Keeping at , but IMHO this should be integrated with AppConfiguration (introduced by #3452582) — see MR review.

  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Merged in upstream, CI should be green again 👍

  • 🇫🇮Finland lauriii Finland

    This looks pretty nice! It would be super cool if we could slightly smoothen the transition when zooming. This can be a follow-up but could be worked on here too in case you're interested in this 😊

  • 🇮🇳India gauravvvv Delhi, India

    Addressed feedback on using AppConfiguration as well smoothen the transition when zooming

  • Pipeline finished with Failed
    5 months ago
    Total: 190s
    #236222
  • 🇮🇳India gauravvvv Delhi, India

    Gauravvvv changed the visibility of the branch 3463307-zoom-interface to hidden.

  • 🇮🇳India gauravvvv Delhi, India

    Gauravvvv changed the visibility of the branch 3463307-zoom-interface to active.

  • Pipeline finished with Failed
    5 months ago
    #236866
  • Pipeline finished with Failed
    5 months ago
    Total: 203s
    #236878
  • Pipeline finished with Failed
    5 months ago
    Total: 195s
    #236880
  • Status changed to Needs work 5 months ago
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Unit tests and E2E tests are failing … 😅

  • Assigned to gauravvvv
  • 🇮🇳India gauravvvv Delhi, India
  • Issue was unassigned.
  • Status changed to Needs review 5 months ago
  • 🇮🇳India gauravvvv Delhi, India
  • Pipeline finished with Failed
    5 months ago
    Total: 192s
    #241808
  • Status changed to Needs work 5 months ago
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Still not passing tests … 😅 why are you marking this ? 🤔

  • 🇮🇳India gauravvvv Delhi, India

    Hi @Wim Leers, I changed the status to needs review before the test results.

  • Pipeline finished with Failed
    5 months ago
    Total: 254s
    #243977
  • First commit to issue fork.
  • Assigned to jessebaker
  • Status changed to Active 4 months ago
  • Assigned to bnjmnm
  • Status changed to Needs review 4 months ago
  • 🇬🇧United Kingdom jessebaker

    This is now ready for review. I picked up from the work by @gauravvvv and implemented the suggestion from @lauriii in #10. Zoom controls now exist in their own React component and an array of tests have been added (and the existing tests cleaned up as a result of me getting absolutely stuck on a weird race condition that seemingly was nothing to do with this issue!)

  • Issue was unassigned.
  • Status changed to Needs work 4 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI

    Looking good - got some nits and bits in the MR that I'm sure can be addressed pretty easily.

  • Assigned to gauravvvv
  • 🇮🇳India gauravvvv Delhi, India
  • Assigned to bnjmnm
  • Status changed to Needs review 4 months ago
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Awesome progress here! 👏

    Can we get an updated GIF in the issue summary to showcase that awesomeness? 🙏😇

    Also: AFAICT this is ready for review! 😄

  • 🇳🇱Netherlands balintbrews Amsterdam, NL

    Just adding a comment here to note that there is some testing code added in Include component props form in undo Needs review (commit in MR: 5aa96e) which should be updated once this issue lands and we have the `loadURLandWaitForXBLoaded` command available.

  • First commit to issue fork.
  • Status changed to Needs work 4 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI
  • Issue was unassigned.
  • 🇺🇸United States bnjmnm Ann Arbor, MI
  • 🇺🇸United States hooroomoo

    Removed the debugging controls from the PoC and updated the IS accordingly. I don't think there is really a need for them right now and we can easily add them back if that changes in the future.

  • Assigned to bnjmnm
  • Status changed to Needs review 4 months ago
  • Pipeline finished with Skipped
    4 months ago
    #266235
  • Issue was unassigned.
  • Status changed to Fixed 4 months ago
  • 🇺🇸United States bnjmnm Ann Arbor, MI
  • 🇫🇮Finland lauriii Finland

    So nice to see this improvement land! 🚀 🎉

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024