- Issue created by @wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺This would've prevented @lauriii from having to file 🐛 TypeError on a clean installation Closed: duplicate . He marked that as , so that helps justify this issue's priority 👍 
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺📌 Add component instance edit form to contextual panel RTBC landed! This can now be worked on. 👍 
- 🇺🇸United States bnjmnm Ann Arbor, MIMR I'm pushing up is built on top of 📌 Remove dependency on sdc_test Needs review as the changes there make it unnecessary to manually add components. 
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺#5: 📌 End-to-end test that tests both the client (UI) and server Active is in 👍 
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺AFAICT 🐛 Cypress teardown should check for dbUrl truthiness, not length Fixed and 🐛 hard codes ids, leading to multiple. Fixed were discovered while working on this? Also: 📌 Cypress test infrastructure clean-up + baseline E2E test Active landed, so updating the issue summary :) 
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺Found the root cause for the phpcsfailures: 📌 CI: phpcs job failing due to upstream changes in Drupal core: unused variables in catch statements now disallowed Fixed .
- Issue was unassigned.
- Status changed to Needs reviewover 1 year ago 9:31pm 17 July 2024
- Assigned to jessebaker
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺Looks great! Just one major question about appConfiguration(introduced in #3452582) vsdrupalSettings, and I have a concrete proposal that AFAICT should work fine: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...If @jessebaker could review it from the front-end perspective, then @bnjmnm can address our feedback and we can land this important milestone later today! 😊 
- Assigned to bnjmnm
- Assigned to wim leers
- 🇺🇸United States bnjmnm Ann Arbor, MII think it just needs @Wim Leers signoff on the MR and we're good. 
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺Just one remark about how both main.ts(to populateappConfiguration) anddummyPropsFormneeded to interact withdrupalSettings, but holding off merging this super important (because very stabilizing) MR on that makes no sense.See https://git.drupalcode.org/project/experience_builder/-/merge_requests/1.... @hooroomoo is out today and is the owner for /submodules/xb_vite/. But the change being made to that is more Drupal-back-end-related than it is hot module reloading related, so I'm bypassing the need for their approval.
- Issue was unassigned.
- Status changed to RTBCover 1 year ago 7:33am 19 July 2024
- 
            
              Wim Leers →
             committed d19b05b1 on 0.x authored by 
            
              bnjmnm →
            
Issue #3461435 by bnjmnm, Wim Leers, lauriii, jessebaker: End-to-end... 
 
- 
            
              Wim Leers →
             committed d19b05b1 on 0.x authored by 
            
              bnjmnm →
            
- Status changed to Fixedover 1 year ago 7:34am 19 July 2024
- Automatically closed - issue fixed for 2 weeks with no activity.