- Issue created by @Wim Leers
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
This would've prevented @lauriii from having to file 🐛 TypeError on a clean installation Closed: duplicate . He marked that as , so that helps justify this issue's priority 👍
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
📌 Add component instance edit form to contextual panel RTBC landed! This can now be worked on. 👍
- 🇺🇸United States bnjmnm Ann Arbor, MI
MR I'm pushing up is built on top of 📌 Remove dependency on sdc_test Needs review as the changes there make it unnecessary to manually add components.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
#5: 📌 End-to-end test that tests both the client (UI) and server Active is in 👍
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
AFAICT 🐛 Cypress teardown should check for dbUrl truthiness, not length Fixed and 🐛 hard codes ids, leading to multiple. Fixed were discovered while working on this?
Also: 📌 Cypress test infrastructure clean-up + baseline E2E test Active landed, so updating the issue summary :)
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Found the root cause for the
phpcs
failures: 📌 CI: phpcs job failing due to upstream changes in Drupal core: unused variables in catch statements now disallowed Fixed . - Issue was unassigned.
- Status changed to Needs review
about 2 months ago 9:31pm 17 July 2024 - Assigned to jessebaker
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Looks great! Just one major question about
appConfiguration
(introduced in #3452582) vsdrupalSettings
, and I have a concrete proposal that AFAICT should work fine: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...If @jessebaker could review it from the front-end perspective, then @bnjmnm can address our feedback and we can land this important milestone later today! 😊
- Assigned to bnjmnm
- Assigned to Wim Leers
- 🇺🇸United States bnjmnm Ann Arbor, MI
I think it just needs @Wim Leers signoff on the MR and we're good.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Just one remark about how both
main.ts
(to populateappConfiguration
) anddummyPropsForm
needed to interact withdrupalSettings
, but holding off merging this super important (because very stabilizing) MR on that makes no sense.See https://git.drupalcode.org/project/experience_builder/-/merge_requests/1....
@hooroomoo is out today and is the owner for
/submodules/xb_vite/
. But the change being made to that is more Drupal-back-end-related than it is hot module reloading related, so I'm bypassing the need for their approval. - Issue was unassigned.
- Status changed to RTBC
about 2 months ago 7:33am 19 July 2024 -
Wim Leers →
committed d19b05b1 on 0.x authored by
bnjmnm →
Issue #3461435 by bnjmnm, Wim Leers, lauriii, jessebaker: End-to-end...
-
Wim Leers →
committed d19b05b1 on 0.x authored by
bnjmnm →
- Status changed to Fixed
about 2 months ago 7:34am 19 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.