- Issue created by @wim leers
- Status changed to Postponed
5 months ago 10:29am 15 July 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Add component instance edit form to contextual panel RTBC must land first.
- Status changed to Active
5 months ago 12:57pm 15 July 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
📌 Add component instance edit form to contextual panel RTBC landed! This can now be worked on. 👍
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
I'm still very strongly in favor of writing actual react components for each widget with a way for people to swap them in.
We did this in decoupled LB. It's a lot less magic. - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I'm still very strongly in favor of writing actual react components for each widget with a way for people to swap them in. […] It's a lot less magic.
There's no question that there's a lot of complexity. AFAIK writing React-based widgets is intended to become possible too, eventually.
For more context, see my detailed response at #3452512-38: Add component instance edit form to contextual panel → .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This blocks 📌 Component props form: map textarea, bool, and select elements to React components Fixed .
- Merge request !109Resolve #3461422 "Less terrible component props form" → (Merged) created by wim leers
- Assigned to bnjmnm
- Status changed to Needs work
5 months ago 2:59pm 19 July 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Note: it looks like this unveiled a minor but high-impact oversight in
semi_coupled.engine
: default values for forms are not rendered when using that engine (see screenshots above), but are rendered when using the default engine (reproduce by adding an early return toexperience_builder_form_component_props_form_alter()
):
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Yay, the MR is green — only the
phpcs
CI job is failing, but that's due to 📌 CI: phpcs job failing due to upstream changes in Drupal core: comments must start with capital letter Active . - First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
5 months ago 12:08pm 22 July 2024 - Status changed to RTBC
5 months ago 1:15pm 22 July 2024 -
bnjmnm →
committed 9b971118 on 0.x authored by
Wim Leers →
Issue #3461422 by Wim Leers, bnjmnm, tedbow: Evolve component instance...
-
bnjmnm →
committed 9b971118 on 0.x authored by
Wim Leers →
- Status changed to Fixed
5 months ago 5:04pm 22 July 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Updated #3462310-10: Component edit form: make form elements match design → and I see @bnjmnm already started working on ✨ Contextual form values need to be integrated with Redux Active 🚀
Automatically closed - issue fixed for 2 weeks with no activity.