- Issue created by @bnjmnm
- Assigned to wim leers
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
will remove the need to deal with
$settings['extension_discovery_scan_tests']
Ah, fair point — that was something I did not notice at all, because I always have that enabled. My bad — sorry for the lack of empathy on my side there 🙈
This is actually only feasible since 📌 Add some basic example SDCs Fixed , because since that issue landed 5 days ago, we now have a few SDCs in the XB module itself — that's why I made XB depend on the
sdc_test
module: to have some SDCs at all. - Assigned to bnjmnm
- Status changed to Needs review
4 months ago 11:04am 15 July 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Green — ready for review by @bnjmnm, since he spotted this DX problem! 👍
- Issue was unassigned.
- 🇺🇸United States bnjmnm Ann Arbor, MI
Left a comment on the MR about a change I had to make that isn't in-in-in scope but might work well here assuming it isn't something in the PHP that caused the issue. LMK
- Status changed to RTBC
4 months ago 8:51am 16 July 2024 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- @bnjmnm didn't approve this MR 😅
- @bnjmnm's #7 and his sole change suggest he's +1 to this MR
- @bnjmnm did write over at #3461435-5: End-to-end test that tests both the client (UI) and server → that he's built that on top of this MR, because it simplifies things.
Based on 2+3, I think @bnjmnm did intend to approve this MR.
Given the huge impact of 📌 End-to-end test that tests both the client (UI) and server Active for team/project velocity … I'm going ahead and am merging this MR.
- Status changed to Fixed
4 months ago 8:52am 16 July 2024 -
Wim Leers →
committed 272c596a on 0.x
Issue #3461101 by Wim Leers, bnjmnm: Remove dependency on sdc_test
-
Wim Leers →
committed 272c596a on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.