Fix Codestyle issues in 8.x-1.0 branch

Created on 25 April 2024, 11 months ago

Problem/Motivation

phpcs CI jobs currently fail: https://git.drupalcode.org/issue/graphql_webform-3443423/-/jobs/1426695

- SlevomatCodingStandard.TypeHints.DeclareStrictTypes.IncorrectStrictTy 50
- Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma 4

Proposed resolution

Fix the issues.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇩🇪Germany cweiske

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @cweiske
  • Merge request !33Fix phpcs issues → (Open) created by cweiske
  • Pipeline finished with Success
    11 months ago
    Total: 159s
    #156249
  • Pipeline finished with Success
    11 months ago
    Total: 197s
    #156252
  • Pipeline finished with Success
    11 months ago
    Total: 155s
    #156281
  • Assigned to akulsaxena
  • 🇮🇳India akulsaxena

    Working on fixing the remaining phpcs and cspell errors

  • 🇮🇳India akulsaxena

    Hey @pfrenssen
    I tried to make the pipelines all green. so i cloned this issue and solved the phpcs errors and added a cspell.json file to add new words to cspell dictionary
    Those are the only changes i made in the branch
    But the composer build is failing. Can you please have a look?
    Thanks

  • Pipeline finished with Failed
    5 months ago
    Total: 36s
    #315063
  • Pipeline finished with Failed
    5 months ago
    #315064
  • 🇧🇬Bulgaria pfrenssen Sofia

    Thanks for starting this!

    Unfortunately I am not doing any more work on the old 8.x-1.x branch. My agency has moved all their projects to GraphQL 4.x and as such I am only assigned to work on the 2.x branch which supports this version. In my personal time I prefer working on cool new stuff rather than maintaining legacy software ;)

    Maybe one of the other maintainers is available to have a look?

  • 🇮🇳India akulsaxena

    Hey @pfrenssen
    Thanks for replying.
    I'm kinda stuck with this composer build fail issue and can use some help. If any of the maintainers can have a look at it and help me out a little, it'd be great!

  • Pipeline finished with Failed
    5 months ago
    Total: 36s
    #322764
  • Pipeline finished with Failed
    5 months ago
    Total: 53s
    #322768
  • 🇮🇳India akulsaxena

    Hi @carolpettirossi and @kyuubi
    I added the .cspell.json file and added the required words to the dictionary to solve the cspell errors. I did not change the composer.json file. Yet, when I try to create an MR, the pipeline is failing at composer build. Can you please have a look?
    Thanks

  • Issue was unassigned.
  • Status changed to Needs review 22 days ago
  • First commit to issue fork.
  • Pipeline finished with Failed
    22 days ago
    Total: 156s
    #446275
  • Pipeline finished with Failed
    22 days ago
    Total: 136s
    #446280
  • Pipeline finished with Failed
    22 days ago
    Total: 143s
    #446294
  • Pipeline finished with Failed
    22 days ago
    Total: 143s
    #446307
  • Pipeline finished with Failed
    22 days ago
    Total: 203s
    #446317
  • Pipeline finished with Failed
    22 days ago
    Total: 138s
    #446321
  • Pipeline finished with Canceled
    22 days ago
    Total: 127s
    #446328
  • Pipeline finished with Failed
    22 days ago
    Total: 175s
    #446329
Production build 0.71.5 2024