- Issue created by @ankitv18
- @ankitv18 opened merge request.
- 🇮🇳India deepakkm
@ankitv18 when we have already created a separate ticket to fix eslint then its better to fix the issue rather than skipping it
- 🇮🇳India divyansh.gupta Jaipur
I have resolved all eslint errors but it is not reflecting in the pipelines since the tests are failing after i resolved the merge conflicts.
Please review. - 🇺🇸United States phenaproxima Massachusetts
Looks like there are still merge conflicts, can this be rebased?
- 🇮🇳India deepakkm
Changes looks good to me and verified locally too, hence RTBC'ed
- 🇺🇸United States phenaproxima Massachusetts
This isn't fixed, because ESLint still isn't running on CI. From the issue summary:
Remove SKIP_ESLINT from gitlab ci
- 🇺🇸United States phenaproxima Massachusetts
Oh, and we need to target the merge request at the 2.0.x branch. 1.x is no longer under development.
- 🇮🇳India deepakkm
I think due to the rebase the changes were lost from gitlab CI file, may be the rebase was incorrect.