- Issue created by @mglaman
- 🇺🇸United States mglaman WI, USA
This can be worked via storybook. Assigning to myself to track down design screenshots and previous notes.
- 🇺🇸United States mglaman WI, USA
Adding in https://www.drupal.org/files/issues/2025-01-16/selected%20home.jpg → as well
- 🇺🇸United States mglaman WI, USA
Started messing with this and I want to sync w/ balintbrews about using the cmdk library versus Radix primitives directly.
- 🇺🇸United States mglaman WI, USA
I'm working on using cmdk. I'm not 100% sure if it's the best approach since its filtering is based on available items. I'm not sure how well it works searching against a large dataset. https://github.com/shadcn-ui/ui/issues/868 has a related example/problem for combobox that is powered by cmdk. The main benefit is that cmdk has all the accessibility and keyboard interactions.
But the design shows a kebab menu for additional actions, which isn't a normal part of cmdk. I'll push forward a bit more. I don't think we'll lose a lot if it's not the way to go.
- 🇺🇸United States mglaman WI, USA
I quick asked @bostonjillian on how we should handle long page titles and slugs:
We could make this a bit wider, and let's do a character count cap with ellipses for like sentence level titles. Anything more than like 5 words is too long. Hover state, do a tool tip with the full title when hovering over the title.
- 🇺🇸United States mglaman WI, USA
cmdk also doesn't support object values when selected, only strings. And it messes with them per https://github.com/shadcn-ui/ui/issues/889
I know it's been widely adopted, but as I keep researching I keep finding wild workarounds for it for folks using it because of shadcn/ui.
- 🇺🇸United States mglaman WI, USA
Opening an MR. I kept the cmdk code so it can be tried out in Storybook.
Here's some screenshots from implementation w/o cmdk