- Issue created by @penyaskito
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Iβd expect this to trigger a rollback of the transaction, and result in a 4xx response instead of letting the exception go unhandled (and hence the 500).
Thoughts, @tedbow?
- πͺπΈSpain isholgueras
I was able to replicate that yesterday while working on π User is able to create pages with same URL alias Active . I think the transaction doesn't start, but there is no
JsonResponse
with the error/exception returned, and the "2 Errors" with a dropdown appeared, but without message. - πͺπΈSpain isholgueras
I think that this line: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... from π User is able to create pages with same URL alias Active will report correctly all those 500 errors to the client because in this other line: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1..., there is catching the violations and returning a proper
JsonResponse
.Imho, we could postpone this issue, or include this issue into π User is able to create pages with same URL alias Active scope.
- πΊπΈUnited States tedbow Ithaca, NY, USA
I started a branch locally to better handle the error, for example info about the entity that was being processed but I think basic fix is for
ui/src/services/pendingChangesApi.ts
to return error message to the UI instead of console and to not show the "Published" message - πΊπΈUnited States tedbow Ithaca, NY, USA
This error is handled on the back-end but the UI doesn't give any indication, so #2 the transaction actually is rolled back.
- First commit to issue fork.
- Merge request !1374#3536403 send error JSON when non-constraint issues are found, too β (Merged) created by bnjmnm
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Pushed an MR that needs some tweaking to pass CI, but this addresses the issue. Looks like if the try block is caught with anything that isn't a Validation Constraint violation, it throws the error but does not make the FE aware of it. It kinda seemed like that difference was intentional but at worst the MR can motivate us to better explain why.
-
bnjmnm β
committed a1517648 on 1.x
Issue #3536403 by bnjmnm, tedbow, penyaskito, isholgueras, larowlan: 500...
-
bnjmnm β
committed a1517648 on 1.x