- Issue created by @balintbrews
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
balintbrews → credited penyaskito → .
- 🇳🇱Netherlands balintbrews Amsterdam, NL
Crediting people who participated in the conversation that resulted in this issue.
- First commit to issue fork.
- Merge request !1103Issue #3528318: JavaScript component filenames become invalid after hash salt change/rotation → (Merged) created by isholgueras
- 🇪🇸Spain isholgueras
I've pushed a proof of concept of removing the hash by the original id.
I've adapted the tests and expected more things to break but they don't.
- I've created a code component named
nachojs
and added to components. XB createddefault/files/astro-island/nachojs.js
well. - I've modified the nachojs.js file title "nachojs changed title" and it changes well.
I've run all the tests that I've modified and all pass (except for those hash/filename that I expect), but I'll let the CI to run the whole battery.
- I've created a code component named
- 🇺🇸United States mglaman WI, USA
One thought I had was keeping a hash, but making it a hardcoded salt. So v0, v1, v2, etc. Whenever XB has a breaking change, this could be bumped and an upgrade hook written. No idea _why_ a breaking change could happen, but it is atleast an option to load different files?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This looks simpler & more elegant than I dared hope! 😄
-
wim leers →
committed e6f4e68b on 0.x authored by
isholgueras →
Issue #3528318 by isholgueras, wim leers, balintbrews, mglaman,...
-
wim leers →
committed e6f4e68b on 0.x authored by
isholgueras →