attilatilman → created an issue.
I have created a component from scratch through XB. Attached screenshot about example.
attilatilman → created an issue.
attilatilman → made their first commit to this issue’s fork.
attilatilman → made their first commit to this issue’s fork.
attilatilman → made their first commit to this issue’s fork.
I am having the same issue (occurs on immediate indexing) and bumped into this ticket. I did try the MR and works as described. When the issue occurs I can see the warning in the log and the content is waiting to be indexed. On the next cron run or manually starting the indexing process will re-index the content properly.
There is one missing step to reproduce the error. If I understand correctly, then the site already applied a patch from this
issue
🐛
General error: 1205 Lock wait timeout exceeded; try restarting transaction
RTBC
before it got merged into the Autosave form module main branch.
The problem here is, that if someone used a patch to apply the changes before the MR got merged and released, then the index which is added, already on the DB table. Since the index is already there in the DB, update hook should check, is the index already there, if not, add it, otherwise skip adding the index.
This is a specific situation, but I think update hook should take care of this, to make sure every site can apply the changes properly.
I'll create a quick fix shortly.
Pipeline failure is not because of the MR changes, it is a different issue. MR LGTM!
Embed select form is showing whenever a user tries to embed a DAM asset via the CKeditor. First, user picks the asset then clicks on Next: select format. On the next form (which is the EmbedSelectForm) the embed options is not a required field and does not have a default option.
attilatilman → created an issue.
attilatilman → created an issue.
attilatilman → made their first commit to this issue’s fork.
attilatilman → made their first commit to this issue’s fork.
Added extra info on the PR.
attilatilman → created an issue.
MR updated with cache handling.
Added 14th point which helps make the configs form more clean.
attilatilman → changed the visibility of the branch 3446787-if-site-is to hidden.
attilatilman → created an issue.
Added an extra bullet point in https://www.drupal.org/project/acquia_dam/issues/3392227 📌 Various code quality improvements before releasing v1.1.0 stable Postponed and linked this issue in there.
attilatilman → created an issue.
attilatilman → created an issue.
Add a minor simplification.
Oops, accidentally removed one line of code which was not intentional. Updated patch uploaded.
I have came across this problem when I was working on one of my projects. I have tried on D10.1 and D11.dev, but the current patch does not solve the problem. Once the $form['relations']['parent']['#multiple']; is set to FALSE, then the $form_state->getValue('parent'); going to return a string value on form submit. Once the form calls buildEntity() it will throw an error because it expects and array value and uses like this: array_values($form_state->getValue('parent'));. Since the return value is going to be a string it will fail. I have came up with a quick fix which will check if the return value is an array or not.
attilatilman → created an issue.