- Issue created by @attilatilman
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
@attilatilman โ Thanks for reporting the issue. Hopefully, we will be close enough to release the first RC version of 1.1.x branch within weeks. After that, our key focus will be ironing out all these and similar issues of the upgrade path from 1.0.x versions. Therefore leaving this issue in Active status until then.
Iโm experiencing this same issue. Iโd just like to know if itโs something I need to worry about or if I can ignore it while itโs being resolved. Thanks.
- First commit to issue fork.
- ๐ฎ๐ณIndia rajeshreeputra Pune
@attilatilman, @ricardo garcรญa, could you please let me know from which version you upgraded to Acquia DAM 1.1.0-beta5?
Thank you! - ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Root cause found which is quite a lame coding mistake, actually: our 2 field definitions with different types (File / Image) both received the same field storage definition (source code):
Tomorrow morning I will open a merge request including the fix together with some minor improvements as well.
- Merge request !90#3481691 โ [9008] Fix mistakenly assigned field storage definition in DB update hook โ (Merged) created by Balu Ertl
- ๐ฎ๐ณIndia ankitv18
Overall changes looks ~~ just added one minor code improvement and on validating the changes on local I've found no more php warnings.
Marking this one RTBC
Feel free to change the status if anyone else having the suggestions.
- ๐บ๐ธUnited States japerry KVUO
Mostly looks good, except the update not only needs to be fixed, but a new update needs to be made to fix the error as well. Alternatively, you can increment the update hook number, but you may need to account for those who already ran the update.
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
The screenshot inserted into my comment on GitLab does not appear here on Dโคorg, so pasting here its link: https://git.drupalcode.org/project/acquia_dam/-/merge_requests/90#note_4...
-
japerry โ
committed 5b59f273 on 1.1.x authored by
baluertl โ
uecnre#3481691 โ [9008] Fix mistakenly assigned field storage definition...
-
japerry โ
committed 5b59f273 on 1.1.x authored by
baluertl โ
-
japerry โ
committed 5b59f273 on acms-3785-onsite-asset-storing-improvements authored by
baluertl โ
uecnre#3481691 โ [9008] Fix mistakenly assigned field storage definition...
-
japerry โ
committed 5b59f273 on acms-3785-onsite-asset-storing-improvements authored by
baluertl โ
- ๐ญ๐บHungary Balu Ertl Budapest ๐ช๐บ
Now tested: when upgrading from
1.0.14
stable to1.1.x
dev version, after running$ drush updb
no any error messages appear on the /admin/content/media page. Automatically closed - issue fixed for 2 weeks with no activity.