EmbedSelectForm radios does not have a default option

Created on 18 October 2024, 6 months ago

Problem/Motivation

Embed select form radios field does not have a default option and the field is not required. This means whenever a user gets to this page and the media type is not DAM image, or it is image but with fewer than 5 select options, then there is no default selected radio button. Regardless the user can click Insert selected button and the asset will be in the text editor. When the asset is inserted, and the user clicks on it, then the appearing media toolbar does not show which embed code it is rendered with and sometimes the embed code selection does not show at all.

Probably the easiest fix is just add a default value to the radios field or make it required. I assume that would fix the media toolbar as well. (I have the same problem in 1.0.14 and 1.1.0-beta5 as well)

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡­πŸ‡ΊHungary attilatilman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @attilatilman
  • Can you please! Provide me more information to reproduce this.

  • πŸ‡­πŸ‡ΊHungary attilatilman

    Embed select form is showing whenever a user tries to embed a DAM asset via the CKeditor. First, user picks the asset then clicks on Next: select format. On the next form (which is the EmbedSelectForm) the embed options is not a required field and does not have a default option.

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    @ananya.k β†’ thanks for beeing active in the Drupal community. As a general thumb of rule: please do not set issue statuses into β€œPostponed (maintainer needs more info)” state on contrib modules where you are not maintainer. If you feel the issue description is not quite clear enough, then request clarification by simply writing a comment about that, but you don't need to set the issue status for this.

    @attilatilman β†’ Thanks for reporting, I was also bothered by these empty set of radio buttons indeed. The merge request for the epic of refactoring thumbnail handling fixes this by setting the newly introduced remotely_referenced_thumbnail_image render mode the default. (The reasoning behind this is the only single embed mode that is universally applicable among all the media types.) Although does not make the radio button field required. Therefore leaving this issue in Active status until the epic gets merged and a new version is being released with a stability level of RC at least.

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί

    Resolved in 1.1.x-dev branch:

  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
  • πŸ‡­πŸ‡ΊHungary Balu Ertl Budapest πŸ‡ͺπŸ‡Ί
Production build 0.71.5 2024