- Issue created by @attilatilman
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
See the diagram ā in ⨠The status badge should indicate if there are changes to the page Active .
isNew
is computed by this heuristic:private function contentEntityIsConsideredNew(string $current_entity_label, EntityTypeInterface $entity_type): bool { return $current_entity_label == ApiContentControllers::defaultTitle($entity_type); }
+
public static function defaultTitle(EntityTypeInterface $entity_type): TranslatableMarkup { return new TranslatableMarkup('Untitled @singular_entity_type_label', ['@singular_entity_type_label' => $entity_type->getSingularLabel()]); }
Together, they mean that this code from this issue's MR:
// Update title and status. $duplicate->set('title', $duplicate->label() . ' (Copy)'); $duplicate->set('status', FALSE);
⦠will never result in
isNew: true
for duplicates.That heuristic was introduced in ⨠The status badge should indicate if there are changes to the page Active 's BE MR. This MR will have to refine that heuristic.
- First commit to issue fork.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Given @larowlan's work on š Include the preview HTML in the layout controller payload Active , I think he's probably best positioned to review this.
- First commit to issue fork.
- š¦šŗAustralia larowlan š¦šŗš.au GMT+10
@attilatilman that test is passing locally for me, so I think it might just be a random fail
I've merged origin/0.x and pushed to your branch - š¦šŗAustralia larowlan š¦šŗš.au GMT+10
Looks good to me, gave it another review and a manual test
- šŗšøUnited States mglaman WI, USA
Assigning to @wim-leers for "The change requests must be completed or resolved."
- First commit to issue fork.
-
lauriii ā
committed 35a4e60e on 0.x authored by
attilatilman ā
Issue #3510925 by attilatilman, mglaman, larowlan, wim leers: Allow CMS...
-
lauriii ā
committed 35a4e60e on 0.x authored by
attilatilman ā
- š«š®Finland lauriii Finland
Did the honors to merge this given that we had code owner approvals.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Seems like we missed an edge case here: š Page duplication in navigator results in blank title in editor panel Active .
- Status changed to Fixed
7 days ago 1:54pm 7 May 2025 Automatically closed - issue fixed for 2 weeks with no activity.