PHPUnit Next Major tests failing

@longwave pointed out that 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Active was only added to 11.x. The current just switches our phpunit (next major) to use 11.1.x. Assuming this passes test I suggest we commit this and leave the issue to remove the need for the override

Assigning to @wim leers because he needs to .gitlab-ci.yml changes

📌 CI: update to 1.6.3 of the GitLab CI Template Active also pins to 11.1.x, maybe worth doing that instead as Stylelint is also failing but upgrading the template will eventually unblock that via 📌 Update Stylelint formatter for Stylelint 16 Active

I can reproduce the fail locally with

$ ddev xb-set-core-version 11.x-dev
$ ddev test tests/src/Kernel/Plugin/Field/FieldType/ComponentTreeItemTest.php --filter testInvalidField@valid.*props

1) Drupal\Tests\experience_builder\Kernel\Plugin\Field\FieldType\ComponentTreeItemTest::testInvalidField with data set "valid values using static props" (['{"a548b48d-58a8-4077-aa04-da9...ts"}}}', '{"dynamic-static-card2df":{"h...ue"}}}'], [])
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 []
+Array &0 [
+    'field_xb_demo.0' => Array &1 [
+        0 => 'The array must contain a "tree" key.',
+        1 => 'The array must contain a "props" key.',
+    ],
+]

/var/www/html/web/modules/contrib/experience_builder/tests/src/Kernel/Plugin/Field/FieldType/ComponentTreeItemTest.php:233

At a guess, this might be why:

 Drupal\experience_builder\Plugin\ComponentPluginManager:
    decorates: Drupal\Core\Theme\ComponentPluginManager
    parent: Drupal\Core\Theme\ComponentPluginManager
    arguments: ['@entity_type.manager', '@state']

Might be worth trying with 📌 Install modules with container_rebuild_true set by themselves Active applied.

📌 Install modules with container_rebuild_true set by themselves Active indeed does fix it.

Why is the writing component info to state done as a decorator? Could this not be a separate service that operates on e.g. hook_rebuild()?

📌 Install modules with container_rebuild_true set by themselves Active landed so this should no longer be necessary - @tedbow can you confirm?

We should still do 📌 CI: update to 1.6.3 of the GitLab CI Template Active .

re #12

landed so this should no longer be necessary - @tedbow can you confirm?

re-running tests on 0.x. https://git.drupalcode.org/project/experience_builder/-/pipelines/364038

there is e2e test that also appears to be failing but that is unrelated. see 📌 Remove leftover wait() in empty canvas e2e test Active

Looks like it is failing for different reason https://git.drupalcode.org/project/experience_builder/-/pipelines/364038

I triggered the jobs to re-run on the same pipeline so I am not sure we can see the previous results

Seeing if I can re-run the pipeline here with a new commit

Yep still failing

Spotted this too yesterday, thanks for jumping in! 👍🙏

If 11.1.x passes I would suggest we use that and then leave this issue as critical. Only so many people can probably work on figuring this out and meanwhile it would good if other issues could get committed. Also maybe 11.x will be receiving a lot of commits while Drupalcon Singapore is going on?

+1

I think we should do 📌 CI: update to 1.6.3 of the GitLab CI Template Active which will test against 11.1 and 10.4 and is currently green, then we can enable OPT_IN_TEST_NEXT_MINOR to add 11.2 but that's not critical to complete until closer to the release of 11.2.0.

Oh, even better! Looking 👀

(The "+1" was referring to "let's unblock this ASAP".)

Just reviewed #3480805 in depth, and pleased to say I was able to RTBC it! 🚀 Yay for one temporary work-around avoided, and the correct/long-term solution being ready at the same time! 🥳

📌 CI: update to 1.6.3 of the GitLab CI Template Active is in — is there anything left to do here? 😊

Well, we should now opt in to "next minor" in our CI config and then fix the failure.

👍 — retitling.

longwave → changed the visibility of the branch 3492722-phpunit-next-major to hidden.

Nice, that seems to be uncovering either not previously observed bugs or 11.2.x has changed in some way — because tests are failing with unmet config dependencies! 😬

Also:

Warning: Undefined array key "label" in /builds/project/experience_builder/web/core/lib/Drupal/Core/Field/FormatterBase.php on line 80

… this seems an upstream bug in core?

This is less urgent than many other MRs, so unassigning @longwave.