Contrib.social

Remove hardcoded parentheses from edit links in checkout review pane titles

Open on Drupal.org →
Created on 14 April 2018, about 7 years ago
Updated 10 July 2025, 1 day ago

Problem/Motivation

The "edit" links in checkout review pane titles have hardcoded parentheses ( ) around them. These parentheses are impossible to theme separately, they can only inherit CSS properties of the pane title.

I can theme the "edit" link itself, but the appearance of the parentheses around the link is impossible to modify separately.

Proposed resolution

Possible solutions:

  1. Removing the parentheses completely and wrapping the edit link in a <span class="checkout-review-edit-link">.
  2. Wrapping the edit link AND the parentheses in a <span class="checkout-review-edit-link"> with a class.
  3. Making the parentheses part of the "edit" link text string.

I suggest 1st option, removing the parentheses completely to make the "edit" link themeable without limitations. For example if I want to show it as a button, the parentheses are unnecessary. If I want parentheses, I can still put them theree with :before and :after pseudo-classes.
3rd option could offer the same but it doesn't feel nice.
If we go with 1st option, we should add this css so it doesn't break appearance on existing sites.

.checkout-review-edit-link:before {
content: "(";
}
.checkout-review-edit-link:after {
content: ")";
}

User interface changes

Will remove parentheses from around edit links in checkout review pane titles. This will be worked around with the CSS proposed above.

📌 Task
Status

Needs review

Version

3.0

Component

Checkout

Created by

🇭🇺Hungary dr. gubó

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024