- Issue created by @rkoller
- 🇵🇰Pakistan akhtardaha
I was able to reproduce this issue and I have created the patch.
- 🇩🇪Germany jurgenhaas Gottmadingen
@akhtardaha thank you for your contribution. Please turn this into an issue fork to create an MR so that the tests can pick this up and run before we spend time reviewing this. And to do that, CSS files don't get created or edited directly, please edit the SCSS sources and then run the tools to compile that into CSS.
- @akhtardaha opened merge request.
- 🇩🇪Germany rkoller Nürnberg, Germany
thanks for the MR! I've taken a look at the interface not the code, and noticed a few details:
From the points listed in the proposed resolution section the background of the warning message looks good now. thanks! The other details probably need some more work:
- in light mode the entire background color for the sidebar remains homogenous while in dark mode when edited the navigation blocks have now the lighter
rgb(59,59,63)
(--admin-toolbar-color-gray-050
) instead of the general darkerrgb(42,42,45)
(--admin-toolbar-color-white
) background color. I would suggest to go with the darker color (rgb(42,42,45)
) for the navigation block background as well. - another detail not listed in the issue summary yet, but from my perspective within the scope of the issue, but it could also moved to a follow up if necessary, the outline
rgb(0,0,0)
for the active navigation block has a too low color contrast againstrgb(42,42,45)
. it has a color contrast of1.5:1
but3:1
is required. - the plus in the
add block
button has a color != the accent color in use - same for the light mode while claro is using a grey color here. havent noticed that before. but it looks odd. i am not sure on what color that plus is based on, is it the same for every accent color in light mode and the same for ever accent color in dark mode? or do the colors also shif based on the chosen accent and focus color? or is it one consistent color for the plus in light and another in dark mode?
The rest of the remaining issues (current menu item, navigation block title labels, expand and collapse nav button) are already covered in other issues. And i've updated the issue summary adding the detail about the outline of the active navigation block. setting the issue back to needs work.
- in light mode the entire background color for the sidebar remains homogenous while in dark mode when edited the navigation blocks have now the lighter