- Issue created by @kevinquillen
- Status changed to Needs work
about 1 year ago 1:45pm 11 December 2023 - π©πͺGermany jurgenhaas Gottmadingen
I've had a first look into this and it looks really great. Only have a few recommendations and thoughts:
- We're only developing new features in the 2.0.x branch. Please rebase.
- This should not go into the eca_content submodule, we should rather introduce an eca_file submodule which will then receive a few more action plugins as well (see β¨ Add new submodule ECA FileSystem Active .
- This action plugin should not worry about base64 decoding as there is already Tamper: Encode/Decode which also does base64 decoding.
- Also, I wonder if this action should only create a file in the file system. Taking that file to create a managed file entity from it should probably be a separate action plugin. The handling of creating the file should be done similarly to Views: Export query into file
- There are a couple of issue regarding coding standards, they will be tested and reported when pushing to the 2.0.x branch and should then also be removed.
Let me know if you feel that we should first build the eca_file submodule foundation in the linked issue, if that makes the development here easier to follow-up.
- Assigned to jurgenhaas
- π©πͺGermany jurgenhaas Gottmadingen
I'm looking into this now as part of β¨ Add new submodule ECA FileSystem Active .
-
jurgenhaas β
committed d701e185 on 2.0.x
Issue #3407071 by jurgenhaas, kevinquillen: New action: save file from...
-
jurgenhaas β
committed d701e185 on 2.0.x
- Status changed to Fixed
8 months ago 10:13am 3 May 2024 - π©πͺGermany jurgenhaas Gottmadingen
This is now implemented with a much simpler approach: this action plugin requires a file entity and a data field, which contains the content that should be written to the file of the given entity.
This way, it can be used in all different scenarios. First you create a file entity and define the schema, filename, extension, etc. there. Then you prepare the file content in a token, which then gets written to that file. Fully flexible and allows the site builder to do anything around writing data to files.
Closing the MR for that reason, since this is now already in 2.0.x-dev
Automatically closed - issue fixed for 2 weeks with no activity.